Summary:ASTERISK-07046: [patch] print a human-friendly warning message about codecs
Reporter:Denis Smirnov (mithraen)Labels:
Date Opened:2006-05-29 06:46:11Date Closed:2006-08-15 17:29:08
Versions:Frequency of
Environment:Attachments:( 0) sip_debug.patch
Description:1. When we show voice codecs, we must show _only_ voice codecs
2. Codec names is more interesting for user than numbers :)
Comments:By: Andrey S Pankov (casper) 2006-05-29 11:31:37

Why not just:
+ char s1[512], s2[512], s3[512];

And then 'sizeof(sX) - 1' (not sure ' - 1' is really needed here)...

By: Denis Smirnov (mithraen) 2006-05-29 12:10:23

Hm. Yes, you are right.
I think that slen variable would be eliminated by compiler, but when I test I see that it's not eliminated :(

By: Denis Smirnov (mithraen) 2006-05-29 12:13:11

Thanks Casper, I update patch.

By: Andrey S Pankov (casper) 2006-05-29 12:26:41

And maybe other such instances in chan_sip as well please...

By: Olle Johansson (oej) 2006-06-02 02:09:36

Well, this patch prints a string as %d... But I get the meaning. guess testing wasn't that extensive ;-)

By: Andrey S Pankov (casper) 2006-06-02 12:33:53

&ASTERISK-1037;&ASTERISK-1093; ;)

By: Serge Vecher (serge-v) 2006-06-28 10:08:41

Mithraen: perhaps this could also be changed to display codec name and codec number in parenthesis?

By: Denis Smirnov (mithraen) 2006-07-01 01:33:15

Patch updated

By: Russell Bryant (russell) 2006-08-15 17:29:08

added to the trunk in revision 39933, thanks!