Summary:ASTERISK-07010: [patch][post 1.4] cannot get peer by hostname from realtime storage
Reporter:Noriyuki Suzuki (noriyuki)Labels:
Date Opened:2006-05-22 01:27:37Date Closed:2011-06-07 14:03:04
Versions:Frequency of
Environment:Attachments:( 0) asterisk-1.2.5-findpeer.patch
Description:Cannot get peer information from realtime storage when
if SIP hostname specified by host name ( NOT IP address ) and didn't receive REGIST.
I fixed this problem.
See patch file.

Comments:By: Serge Vecher (serge-v) 2006-05-30 09:36:56

noriyuki: thanks for the patch. Can you please fix it up according to the CODING-GUIDELINES document? Hint: use tabs instead of spaces and no curly brackets are needed for single-line if constructs. Thanks.

By: Samuel Tardieu (tardieu) 2006-06-01 04:12:54

It looks like the patch is not thread-safe as gethostbyaddr() may return a pointer to static data (and the designated structure may also contain pointers to static data).

Something modelled after ast_gethostbyname would probably be better.

By: Olle Johansson (oej) 2006-06-01 11:29:37

Do we *really* want to add another storage lookup for this?

By: Olle Johansson (oej) 2006-10-29 15:03:25.000-0600

No response from reporter.