| Summary: | ASTERISK-06992: Spurious check for qe->parent->autofill in app_queue | ||
| Reporter: | Bradley Watkins (marquis) | Labels: | |
| Date Opened: | 2006-05-17 16:26:30 | Date Closed: | 2006-05-17 17:52:02 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | The function is_our_turn in app_queue.c has spurious check for autofill that has already been determined to be false. ****** ADDITIONAL INFORMATION ****** After BJ's change to app_queue to fix autofill behavior, this dubious check remains: if (!qe->parent->autofill) { /* Atomically read the parent head -- does not need a lock */ ch = qe->parent->head; /* If we are now at the top of the head, break out */ if ((ch == qe) || (qe->parent->autofill)) { if (option_debug) ast_log(LOG_DEBUG, "It's our turn (%s).\n", qe->chan->name); As you can see, it's already been determined to be false so there is no sense in checking to see if it's true later. :) This is obviously remaining from the change to autofill behavior. | ||
| Comments: | By: Joshua C. Colp (jcolp) 2006-05-17 17:52:02 Changed in trunk! Thankies! | ||