Summary:ASTERISK-06981: [patch] don't stop recording until hangup (no terminator)
Reporter:julien23 (julien23)Labels:
Date Opened:2006-05-16 01:35:43Date Closed:2006-05-22 10:48:52
Versions:Frequency of
Environment:Attachments:( 0) patch_app_record_no_terminator_v2.diff
( 1) patch_app_record_no_terminator_v3.diff
( 2) patch_app_record_no_terminator.diff
Description:Presently, the app_record stops recording after receiving a '#' DTMF terminator (or a '*' DTMF if option 't' is used). This scheme can be annoying if you don't want to stop recording until real hangup.

The attached patch add the 'x' option to implement this feature keeping compatibility with previous usage of the application.


Patch have been tested in my office and works fine.
Comments:By: Serge Vecher (serge-v) 2006-05-16 08:35:18

Julien, thanks for contributing. A couple of points.

1. New features are patched against trunk. Can you please make a new patch.
2. Can you please get a disclaimer on file.
3. "don't use any terminator key instead of default" -- does this mean that # will still terminate the recording?

By: julien23 (julien23) 2006-05-16 15:52:24

1. New patch against trunk (not tested but should work fine).
2. OK for the disclaimer but how to update the issue content ?
3. Replaced "don't use any terminator key instead of default" by "do not take care of any terminator key (DTMF) and do not stop recording until hangup"

By: julien23 (julien23) 2006-05-16 16:04:51

Anyway, the following description for the app_record don't seem relevant to me :
"If the user should hangup during a recording, all data will be lost and the application will teminate."

The "all data will be lost" is not relevant concerning the recorded call as the record (file) is not lost during hangup. Application terminates with an error but hangup can be intercepted in the dialplan to deal perfectly with the end of the call (do something with the record).

By: Serge Vecher (serge-v) 2006-05-16 16:21:20

julien23: how about for 3) "ignore all terminator keys (DTMF) and do not stop recording until hangup"?

By: julien23 (julien23) 2006-05-18 11:57:38

Fine for me but does not fit in a line.
This one looks good : "ignore all terminator keys (DTMF) and keep recording until hangup"

By: Russell Bryant (russell) 2006-05-19 12:03:11

I think this is ready to go in, but can you please clarify the status of the disclaimer?  Has it been sent in?

By: julien23 (julien23) 2006-05-19 12:17:22

I'm not sure to really understand what is the disclaimer for.
Do I have to send additional file making a disclaimer for including this patch in the asterisk sources with conformance to its license ?

By: Russell Bryant (russell) 2006-05-19 12:29:03

Yes, please take a look at the bottom of the main page of the bug tracker.  You will see links to two different versions of the disclaimer.  You will need to pick one, sign it, and fax it to Digium before we can include your code in Asterisk.

By: julien23 (julien23) 2006-05-22 04:01:41

OK, I sent my disclaimer (simple model) by FAX this morning.

By: Joshua C. Colp (jcolp) 2006-05-22 10:48:52

Put into trunk as of revision 29435! Thanks!