[Home]

Summary:ASTERISK-06977: Priority jumping not working on VoiceMail app with new sintax
Reporter:Alvaro Palma (alvaro_palma_aste)Labels:
Date Opened:2006-05-15 11:36:32Date Closed:2006-05-17 12:11:10
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:In VoiceMail application, if you set:

exten => _pattern,110,VoiceMail(${EXTEN}@mailbox_context,b|j)

in case ${EXTEN} is not a valid mailbox, the "j" flag doesn't work at all. This is because, in the new sintax checking, the priority jumping flag is not checked at all.

The fix is: in apps/app_voicemail.c, change the line 5522 from:

ast_copy_flags(&leave_options, &flags, OPT_SILENT | OPT_BUSY_GREETING | OPT_UNAVAIL_GREETING);

to:

ast_copy_flags(&leave_options, &flags, OPT_SILENT | OPT_BUSY_GREETING | OPT_UNAVAIL_GREETING | OPT_PRIORITY_JUMP);

****** ADDITIONAL INFORMATION ******

Patch file:

5522c5522
<                       ast_copy_flags(&leave_options, &flags, OPT_SILENT | OPT_BUSY_GREETING | OPT_UNAVAIL_GREETING);
---
>                       ast_copy_flags(&leave_options, &flags, OPT_SILENT | OPT_BUSY_GREETING | OPT_UNAVAIL_GREETING | OPT_PRIORITY_JUMP);
Comments:By: BJ Weschke (bweschke) 2006-05-15 12:07:39

do you have a disclaimer on file?
By: Alvaro Palma (alvaro_palma_aste) 2006-05-15 16:26:15

I forgot to include it. Here it goes (hope this is what you need)

Alvaro Palma hereby disclaims all copyright
 interest in the changes and enhancements made by Alvaro Palma
 to the program "asterisk" (the "Program").

 Alvaro Palma affirms that it has no other
 intellectual property interest that would undermine this release, or
 the use of the Program, and will do nothing to undermine it in the
 future.

 Alvaro Palma        ,  May 15th, 2006
 Authorized Signature   Date


 ______________________________
 Title
By: Serge Vecher (serge-v) 2006-05-15 16:30:21

alvaro:

1) Disclaimer needs to be faxed to digium. See the bug gudiliness for fax number.
2) Please upload your patch as a patch file, please.

Thank you!
By: Joshua C. Colp (jcolp) 2006-05-17 12:11:09

Fixed in trunk and 1.2, thanks! But do remember to get a disclaimer on file for any future contributions you may have. PEACE!