| Summary: | ASTERISK-06967: [patch] cdr_pgsql -- some cleanups | ||
| Reporter: | Denis Smirnov (mithraen) | Labels: | |
| Date Opened: | 2006-05-13 04:24:06 | Date Closed: | 2006-05-19 20:35:59 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) seiros.cdr_pgsql.patch | |
| Description: | I think, that cdr_pgsql was not reviewed at all :( | ||
| Comments: | By: Andrey S Pankov (casper) 2006-05-17 14:52:37 What about keeping formatting changes separately? By: Andrey S Pankov (casper) 2006-05-17 14:53:23 And the patch will fail if applied after ASTERISK-6960 By: Andrey S Pankov (casper) 2006-05-17 15:00:18 +static char sqlcmd[2048]; Why do you make it global? It's not used outside pgsql_log(). If you want to do something with it I'd suggest you to localize it under 'if (connected)'. By: Russell Bryant (russell) 2006-05-19 20:35:59 I removed the unused variable and made the user default to asterisk if not specified. If there is anything that you feel is a problem that needs to be addressed, feel free to open a new issue with a new patch. Thanks (rev 28936) | ||