|Summary:||ASTERISK-06960: [patch] cdr_pgsql -- using unix sockets if host not set|
|Reporter:||Denis Smirnov (mithraen)||Labels:|
|Date Opened:||2006-05-11 13:29:54||Date Closed:||2006-05-19 19:57:20|
|Environment:||Attachments:||( 0) cdr_pgsql.patch|
|Description:||I think, that using unix sockets is more secure, then localhost over net.|
On must my installation postgresql hasn't network support at all
|Comments:||By: Andrey S Pankov (casper) 2006-05-15 15:54:38|
And using unix sockets give us more performance afaik...
By: Andrey S Pankov (casper) 2006-05-15 15:56:19
Could you please alter ast_log messages as well?
By: Jared Smith (jsmith) 2006-05-16 11:19:04
This patch is very straighforward, and is a useful addition. I agree with Casper though -- it would be nice if the ast_log messages were updated to indicate that it was going to connect to PostgreSQL on a UNIX socket.
Could you please make that change and update a new patch?
By: Denis Smirnov (mithraen) 2006-05-16 11:41:55
By: Andrey S Pankov (casper) 2006-05-16 13:45:39
Code Review: Failed - casper
By: Denis Smirnov (mithraen) 2006-05-16 13:47:36
Fixed patch uploaded
By: Andrey S Pankov (casper) 2006-05-16 13:51:44
What about cdr_pqgql.conf.sample?
By: Andrey S Pankov (casper) 2006-05-16 13:56:56
*pghostname == '\0'? why not ast_strlen_zero?
And what about removing unused pgdbsock variable?
By: Denis Smirnov (mithraen) 2006-05-17 06:27:50
1. removing unused variables (that was unused before this patch) are cleanup work. Please, read bug guildlines -- defferent patches must be in separate bugs.
2. *pghostname == '\0', because pghostname can't be NULL. But I can use ast_strlen_zero, ok.
By: Denis Smirnov (mithraen) 2006-05-17 06:32:36
By: Russell Bryant (russell) 2006-05-19 19:57:19
added to the trunk in rev 28897, thanks!