[Home]

Summary:ASTERISK-06954: [patch] OSPNext does not handle success/failure correctly
Reporter:eab (eborgstrom)Labels:
Date Opened:2006-05-12 10:44:22Date Closed:2006-05-17 10:21:39
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_osplookup
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-1.2.7.1-app_osplookup.c-ospnext.diff
Description:A problem with OSPNext which causes OSPNEXTSTATUS to be set incorrectly exists within app_osplookup. For instance if the OSP handle has no more routes OSPNEXTSTATUS is still set to SUCCESS when it should be set to FAILED due to a mis-handling of the res variable.

Attached is a patch to correct this issue.
Comments:By: Joshua C. Colp (jcolp) 2006-05-17 09:58:57

Nobody uses OSP I suppose... anyone tested this? Comments? Anything? I hate blindly putting stuff in but if need be... I will
By: eab (eborgstrom) 2006-05-17 10:03:10

We use OSP :)

I've actually already confirmed this problem and fix with Di-Shi from Transnexus

Quote's from email:

Hi Evan,

You are right, the code has some problem. If you look at osplookup_exec, you
will find where the strange control flow comes from.

In fact, we have rewritten the whole osp module in Asterisk in SVN trank.
Digium froze 1.2, so our code can only be put in SVN trunk. Please feel free
to submit a patch for this issue. I believe it will be accepted quickly.

Thanks,

Di-Shi Sun.
By: Serge Vecher (serge-v) 2006-05-17 10:11:57

eborgstrom: I have located the patch Di-Shi Sun (homesick) has mentioned. Can you please apply and test the patch in bug 6981 to see if it fixes the issue in your bug also? Thanks.
By: Joshua C. Colp (jcolp) 2006-05-17 10:21:39

Fixed in 1.2, thankies!