| Summary: | ASTERISK-06947: [patch] When using ODBC storage message count always results in error | ||
| Reporter: | Chris Field (cfieldmtm) | Labels: | |
| Date Opened: | 2006-05-10 12:02:33 | Date Closed: | 2006-05-18 11:33:49 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_voicemail |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) patch_for_messagecount_error.patch | |
| Description: | When using the database storage for voicemail message count always results in error. Problem results from the messagecount function returning '1' when it is successful and '0' when it fails, this is not correct behavior. Patch is attached to fix. I will fax in disclaimer shortly. ****** ADDITIONAL INFORMATION ****** OS: Red Hat Enterprise Linux ES release 3 (Taroon) Mysql: mysql Ver 14.7 Distrib 4.1.10, for pc-linux-gnu (i686) mysqlclient library: libmysqlclient.so.14.0.0 | ||
| Comments: | By: Will McCown (flynwill) 2006-05-15 13:31:20 I found this one independantly. When I see things like this I tend to wonder if it was "just a goof" or if that was there to prevent untested code from being used. Can we check with whoever wrote messagecount() for ODBC? By: Joshua C. Colp (jcolp) 2006-05-18 11:33:48 Fixed in 1.2 and trunk, the actual return values are -1 on error and 0 on success. Thanks for bringing this up though! | ||