|Summary:||ASTERISK-06945: [patch] MeetMeAdmin Additional Features (Volume)|
|Reporter:||Daniel Mikusa (dmikusa)||Labels:|
|Date Opened:||2006-05-10 10:56:03||Date Closed:||2006-05-25 16:31:37|
|Environment:||Attachments:||( 0) app_meetme-220.127.116.11-2.patch|
( 1) app_meetme-trunk.patch
|Description:||I've added the following features into the MeetMeAdmin application all pertaining to volume settings.|
'S' -- Raise entire conference speaking volume
's' -- Lower entire conference speaking volume
'V' -- Raise entire conference listening volume
'v' -- Lower entire conference listening volume
'T' -- Raise one user's talk volume
't' -- Lower one user's talk volume
'U' -- Raise one user's listen volume
'u' -- Lower one user's listen volume
'R' -- Reset all user's volume settings
'r' -- Reset one user's volume settings
****** ADDITIONAL INFORMATION ******
My original patch is for 18.104.22.168, but I'll get one for the SVN trunk as well.
|Comments:||By: Serge Vecher (serge-v) 2006-05-10 11:09:54|
1. can you please also attach a patch for trunk?
2. as per coding guidelines, single line if ... else ... constructs don't need curly brackets.
3. 'while(user)' needs a space, as in 'while (user)'
By: Daniel Mikusa (dmikusa) 2006-05-10 11:48:42
vechers made the changes you suggested. Also set some other if/else and while statements in 'admin_exec' to fit the coding guidelines.
Uploaded a patch for the trunk, and uploaded a patch for 22.214.171.124.
By: Joshua C. Colp (jcolp) 2006-05-17 11:59:53
I'm changing this to be SVN for version due to the fact that no new features are accepted against the 1.2 branch or a release, only in trunk. If all further development could be done against trunk for this - that would be just peachy.
By: Jeffrey C. Ollie (jcollie) 2006-05-19 22:22:30
I've opened a branch for tracking this bug:
I had to modify the code to use the linked list macros - app_meetme was converted after the original patch was generated.
By: Joshua C. Colp (jcolp) 2006-05-25 16:31:36
In trunk as of revision 30427. You can close out your branch jcollie!