[Home]

Summary:ASTERISK-06931: q931_dumpie calls pri_message multiple times
Reporter:Peter Childs (peter childs)Labels:
Date Opened:2006-05-09 02:01:15Date Closed:2006-06-02 09:34:43
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) log_cleanup.diff
Description:The function q931_dumpie in q931.c calls pri_message(..) multiple times causing cluttered logfiles.

****** ADDITIONAL INFORMATION ******

q931_dumpie calls pri_message multiple times prior to calling pri_message with a terminating character.  This causes asterisk log files to contain difficult to read and confusing logging.

Example.  

May  9 13:54:12 VERBOSE[12535] logger.c: > [May  9 13:54:12 VERBOSE[12535] logger.c: > [18May  9 13:54:12 VERBOSE[12535] logger.c: > [18 03May  9 13:54:12 VERBOSE[12535] logger.c: > [18 03 a9May  9 13:54:12 VERBOSE[12535] logger.c: > [18 03 a9 83May  9 13:54:12 VERBOSE[12535] logger.c: > [18 03 a9 83 81May  9 13:54:12 VERBOSE[12535] logger.c: > [18 03 a9 83 81]

This could be made cleaner with a change, such as what was implemented in q921.c to resolve the same issue...

http://svn.digium.com/view/libpri/trunk/q921.c?r1=79&r2=84
Comments:By: Serge Vecher (serge-v) 2006-05-25 20:58:21

Peter: you didn't specify the SVN version ... Is this an issue in 1.2.7.1?
By: Peter Childs (peter childs) 2006-05-28 19:51:17

Its in libpri-1.2.2 (released tar), plus I just checked HEAD and its the same.
By: Matthew Fredrickson (mattf) 2006-06-01 13:41:56

Ok, I just uploaded a patch that will probably fix it.  If you can test it to confirm that it fixes your problem, I'll put it in.
By: Peter Childs (peter childs) 2006-06-01 17:55:06

Yes thats great.  Thanks.
By: Matthew Fredrickson (mattf) 2006-06-02 09:34:43

Fixed in 1.2 and trunk