Summary:ASTERISK-06920: [patch] no Pickup on NoCDR and unused Flag AST_CDR_FLAG_POST_DISABLED
Reporter:thaeger (thaeger)Labels:
Date Opened:2006-05-08 10:48:16Date Closed:2006-05-22 11:10:30
Versions:Frequency of
Environment:Attachments:( 0) th_pickup.patch
Description:Hi all,

I've found out that Pickup cannot be used if NoCDR will also be used in the Dialplan. Furthermore you cannot pickup any call except you know exactly the extension and the context. But what if the dial comes through a macro with a user defined extension, then you are never be able to pickup the wanted call. I've patched app_directed_pickup so that you can mark any incoming calls with a channel variable named "PICKUPMARK" for later pickup with "Pickup(exten@PICKUPMARK) independent in wich extension or context the channel currently is. The next Porblem was that Pickup searchs the corresponding channel throug the cdr-object of the origin channel. But if you are using the NoCdr application in your Dialplan there is no cdr-object and the pickup fails in any case. After investigating the NoCDR application i've seen that this app deletes the whole cdr! Thats not a good way in my opinion and I also don't know wherefore the AST_CDR_FLAG_POST_DISABLED was created. So instad of setting cdr to NULL I've added this flag to the cdr and inside of cdr.c in function cdr_post I asked for it and act accordingly.

So thats enough chitchat, just see attached patch, maybe someone is able to commit this to svn even though its also a feature enhancement. But in fact, the Pickup application isn't usable in 1.2, and not only if NoCdr will be used, correct me if I'am wrong.


Comments:By: Serge Vecher (serge-v) 2006-05-16 10:27:34

can you please show a high verbosity log of a situation when you use Pickup with NoCDR?

By: Joshua C. Colp (jcolp) 2006-05-16 10:39:50

The Pickup application is usable in 1.2, you just have to know how to use it right and what behavior it exhibits. As for using it with NoCDR, you are indeed correct - you can't. It's because it uses CDR channel to determine what channel to pick up. As for your other changes, I have no qualms with them but your patch will need to be tweaked a bit more (you left in commented out code for example).

By: Joshua C. Colp (jcolp) 2006-05-22 11:10:30

I added your PICKUPMARK stuff in with mods to trunk, as for the CDR changes... I'd suggest going onto the asterisk-dev mailing list... I'm uncomfortable making the changes without a discussion about them.