Summary: | ASTERISK-06857: [patch] Leak in chan_ooh323 during call setup | ||
Reporter: | Claus Holt Futtrup (clausf) | Labels: | |
Date Opened: | 2006-04-27 06:53:42 | Date Closed: | 2006-05-16 15:08:38 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) channel_c.patch | |
Description: | I have discovered a leak, when calling from SIP -> asterisk -> OOH323. The leak in minor and occurs when OOH323 calls AST_QUEUE_CONTROL -> AST_QUEUE_FRAME -> AST_FRDUP. It occurs only in when establish Output from show memory summary frame.c gateway*CLI> show memory summary frame.c 32592 bytes in 291 allocations in function 'ast_frdup' of 'frame.c' 32592 bytes allocated 291 units total This is after 291 calls | ||
Comments: | By: Claus Holt Futtrup (clausf) 2006-04-27 07:50:50 channel.c line 1970 if (prestate == AST_STATE_UP) { ast_log(LOG_DEBUG, "Dropping duplicate answer!\n"); ast_frfree(f); //ADDED BY CF... f = &null_frame; } NOT if (prestate == AST_STATE_UP) { ast_log(LOG_DEBUG, "Dropping duplicate answer!\n"); f = &null_frame; } That fixes the bug By: Serge Vecher (serge-v) 2006-04-27 08:31:13 clausf: can you please get a disclaimer (see The Disclaimer section here http://www.digium.com/bugguidelines.html) on file with Digium? This will greatly facilitate acceptance of your patches into the trunk. Thank you for your contribution! By: Claus Holt Futtrup (clausf) 2006-04-27 09:06:14 working on it By: Claus Holt Futtrup (clausf) 2006-04-27 17:06:30 Should be with Digium now By: Bluce Ree (tasker) 2006-04-28 11:00:36 In 1.2.7.1, it's on line 1955 of channel.c. By: Claus Holt Futtrup (clausf) 2006-04-28 16:44:04 yep that's right By: Bluce Ree (tasker) 2006-04-29 11:11:00 There are probably more such oversights that may be contributing to the H.323 channel lock problem. By: Claus Holt Futtrup (clausf) 2006-04-29 14:02:30 Most likely. I'll continue to look.. The patch was adressed to a leak when using the asterisk-addons->OOH323, not chan_h323 from the asterisk code base. By: Serge Vecher (serge-v) 2006-05-12 14:46:23 clausf: can you please upload your patch as diff patch file please? thanks. By: Claus Holt Futtrup (clausf) 2006-05-15 07:30:22 sure just need to figure out how :-) By: Serge Vecher (serge-v) 2006-05-15 09:42:51 http://www.asterisk.org/developers/Patch_Howto By: Claus Holt Futtrup (clausf) 2006-05-16 05:06:10 Done By: Kevin P. Fleming (kpfleming) 2006-05-16 15:08:37 Fixed in 1.2 (revision 27468) and trunk (revision 27477). Thanks! |