Summary:ASTERISK-06839: [patch] Reloading app_queue.so unpauses all members
Reporter:Johann Hoehn (johann)Labels:
Date Opened:2006-04-24 12:03:18Date Closed:2006-05-04 11:27:59
Versions:Frequency of
Environment:Attachments:( 0) 20060429__queues_reload_unpauses.diff.txt
Description:When the queue module is reloaded(via reload or reload app_queue.so), it causes all queue members that are paused to be unpaused.  Basically pause state is not remembered at all.

I'ved tested with Asterisk 1.2.4, 1.2.7 and trunk all share the same behavior.


I'm using statically defined callback agents.
Comments:By: Tilghman Lesher (tilghman) 2006-04-25 18:08:27

Please test this patch and report back whether it fixes your issue.

By: Johann Hoehn (johann) 2006-04-26 08:37:32

Tested the patch and it partially works.  Agents that are paused are staying paused.  However the queuemembers list for a queue is seeing duplicate entries.

Tested using Asterisk 1.2.7(patch applied cleanly).

By: Tilghman Lesher (tilghman) 2006-04-29 01:46:50

Okay, let's try that patch again.

By: Johann Hoehn (johann) 2006-05-04 10:44:34

The 2nd patch works perfectly.

By: Serge Vecher (serge-v) 2006-05-04 10:49:42

johann: is this issue present in trunk?

By: Johann Hoehn (johann) 2006-05-04 11:04:27

When I submmited the bug, I did a svn checkout of trunk and it had the same problem.  I also tested with 1.2.4 and 1.2.7.

Steps to reproduce the problem:
1) Create a queue with members (I used static)
2) Log the members in (I use agents)
3) Pause some of the members
4) Run reload or reload app_queue.so to see that all members are unpaused

Just updated trunk and the patch does not apply cleanly to it(it does to 1.2.7)

patching file app_queue.c
Hunk #1 succeeded at 306 (offset 8 lines).
Hunk #2 succeeded at 3335 (offset 173 lines).
Hunk #3 FAILED at 3383.
Hunk #4 FAILED at 3402.

By: Tilghman Lesher (tilghman) 2006-05-04 11:27:59

Committed to 1.2, revision 24706.