[Home]

Summary:ASTERISK-06822: [patch] chan_h323 does not build
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2006-04-20 18:04:35Date Closed:2006-05-19 17:55:51
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_h323
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) Makefile-v2.diff
( 1) Makefile-v3.diff
Description:This is due to "DEBUG_THREADS +=" line addition in the recent global Makefile.

The patch also adds clean: target to clean files created by make process
and removes C-only "STDCCFLAGS     += -Wmissing-prototypes" option.
Comments:By: Andrey S Pankov (casper) 2006-04-24 17:05:03

Please commit this little thingy or we'll wait JerJer to do it for ages...

By: Andrey S Pankov (casper) 2006-05-04 16:56:21

Patch updates for current trunk.

By: goestelecom (goestelecom) 2006-05-09 16:06:08

I just tested Makefile-v2.diff from an SVN copy pulled a couple of minutes ago.

pwlib / openh323 pulled fresh a couple of hours ago.  They both compiled cleanly.

OS: FreeBSD 6.1

Issued a "gmake opt" and the compile succeeded without the warning/error messages.

However, returning to the top level Asterisk directory and trying to compile chan_h323 did not succeed.  There was no compile error, there just wasn't an attempt to even try to compile chan_h323.  Tried "gmake clean" followed by a "gmake" but this didn't help matters.

Regards,
Norm

By: jerjer (jerjer) 2006-05-09 16:29:05

Dive into the Makefile [again] to see where it is checking for the PWLib and OpenH.323 libraries, then ensure they are in those directories or find out why the Makefile thinks differently

By: Andrey S Pankov (casper) 2006-05-09 17:31:30

http://developer.berlios.de/project/shownotes.php?group_id=6533&release_id=10001

By: goestelecom (goestelecom) 2006-05-09 17:53:40

Thank you for the hint.  chan_h323 compiles now (albiet with a few warnings).

Regards,
Norm

By: Mike Anikienko (mike anikienko) 2006-05-10 08:19:14

Please, more detailed. I set H323=1, but no change. What i must do with openh323 directories in Makefile?
2 month ago i complile h323 without same problem.

By: Mike Anikienko (mike anikienko) 2006-05-11 02:42:48

I have found a way:
1) patch channels/h323/Makefile
2) make (do same as ./configure)
3) edit build_tools/menuselect_deps H323=1
4) make menuselect (nothing doing, only press 'x' to save into menuselect.makeopts)
5) make -C channels/h323 opt
6) make
7) make install
But why configure cant itself find openh323 libraries?

By: Andrey S Pankov (casper) 2006-05-15 12:01:45

Defines are now in buildops.h file, so the first change for DEBUG_THREADS in not needed.

By: Serge Vecher (serge-v) 2006-05-17 16:40:10

casper: would it be better to file other changes in the new bug and close this one, since the original problem is now fixed?

By: Andrey S Pankov (casper) 2006-05-18 19:58:45

I don't know... :(

By: Russell Bryant (russell) 2006-05-18 21:11:53

casper, if you could update your patch to reflect what is left to be done, I'll get it merged so we can close this out.

By: Andrey S Pankov (casper) 2006-05-19 15:38:42

Updated...

By: Russell Bryant (russell) 2006-05-19 17:55:50

added to the trunk in revision 28834, thanks