[Home]

Summary:ASTERISK-06802: [patch] wrong event structure used in handling of PRI_EVENT_SETUP_ACK
Reporter:Michael Neuhauser (mneuhauser)Labels:
Date Opened:2006-04-18 11:31:30Date Closed:2006-04-27 13:06:09
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:A wrong event structure is used in pri_dchannel():
case PRI_EVENT_SETUP_ACK:
 chanpos = pri_find_principle(pri, e->setup_ack.channel);
 if (chanpos < 0) {
   ...
 } else {
   chanpos = pri_fixup_principle(pri, chanpos, e->ring.call);

The last line should be replaced by:
   chanpos = pri_fixup_principle(pri, chanpos, e->setup_ack.call);

Problem is present in trunk, 1.2.7.1 and 1.2 branch.
Comments:By: richardhh (richardhh) 2006-04-20 10:06:17

Is this related to 6963 ?

http://bugs.digium.com/view.php?id=6963
By: Michael Neuhauser (mneuhauser) 2006-04-20 10:12:58

Re 'Is this related to 6963 ?'

Could be, I've looked into this because of a "pri_fixup_principle: Call specified, but not found?" error (which was fixed by my change). But without detailed debugging one can not be sure that the same thing is happening in 6963.
By: Rudolf E. Steiner (res) 2006-04-27 10:44:31

A compile after patching 'chan_zap.c' of Asterisk 1.2.7.1 says:

----- begin -----
chan_zap.c: in function »pri_dchannel«:
chan_zap.c:9033: error: »pri_event_setup_ack« has no member named »call«
make[1]: *** [chan_zap.o] error 1
make[1]: Leaving directory `/root/src/asterisk-1.2.7.1/channels'
make: *** [subdirs] error 1
----- end -----
By: Matthew Fredrickson (mattf) 2006-04-27 11:13:48

Try checking out the latest 1.2 from svn, I think I should have fixed it.  When I did the code for making channels changes allowed on setup_ack, I made a mistake.
By: Rudolf E. Steiner (res) 2006-04-27 12:50:25

Confirmed.
It seems to be fixed and it works fine.

Thank's for the good work.