[Home]

Summary:ASTERISK-06795: [patch] L option of Dial does not work properly (new case)
Reporter:Peng Yong (ppyy)Labels:
Date Opened:2006-04-17 11:04:58Date Closed:2006-04-18 09:43:43
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch.timelimit2
Description:bug caused by rev 20540:

http://svn.digium.com/view/asterisk/trunk/channel.c?rev=20540&r1=20539&r2=20540&view=diff


moving "config->end_sound" outside cause the problem. it should stop bridge when (time_left_ms <= 0).
Comments:By: Joshua C. Colp (jcolp) 2006-04-17 13:19:21

I just tried using L(30000:15000:5000) without your patch and it worked fine, can you elaborate a bit more?
By: Peng Yong (ppyy) 2006-04-17 21:35:37

joshnet, it's a bug introduced in version 20540 on Sun Apr 16 16:04:22 2006 UTC.

pls update the svn trunk to test it again.
By: Joshua C. Colp (jcolp) 2006-04-17 22:04:39

I tested using revision 21036, and the L option worked fine using what I said previously.
By: Peng Yong (ppyy) 2006-04-18 06:39:16

joshnet, maybe you are so lucky :)

i suggest you to use following patch to get some debug information, the bridge not exit and loop after time limit:

Index: channel.c
===================================================================
--- channel.c   (revision 21096)
+++ channel.c   (working copy)
@@ -3580,6 +3580,7 @@
                       o0nativeformats = c0->nativeformats;
                       o1nativeformats = c1->nativeformats;
               }
+               ast_log(LOG_WARNING, "DEBUG: ---- begin to bridge %d ms\n", ast_tvdiff_ms(nexteventts, ast_tvnow()));
               res = ast_generic_bridge(c0, c1, config, fo, rc, nexteventts);
               if (res != AST_BRIDGE_RETRY)
                       break;
By: Joshua C. Colp (jcolp) 2006-04-18 09:37:47

Apr 22 14:24:28 WARNING[8645]: channel.c:3583 ast_channel_bridge: DEBUG: ---- begin to bridge 14999 ms
   -- Playing 'beep' (language 'en')
Apr 22 14:24:43 WARNING[8645]: channel.c:3583 ast_channel_bridge: DEBUG: ---- begin to bridge 4557 ms
   -- Playing 'beep' (language 'en')
Apr 22 14:24:48 WARNING[8645]: channel.c:3583 ast_channel_bridge: DEBUG: ---- begin to bridge 4559 ms
   -- Playing 'beep' (language 'en')
Apr 22 14:24:53 WARNING[8645]: channel.c:3583 ast_channel_bridge: DEBUG: ---- begin to bridge 4559 ms
   -- Playing 'pbx-invalid' (language 'en')

As you can see it goes fine...
By: Joshua C. Colp (jcolp) 2006-04-18 09:40:38

Aha... okay, I get it now. I'll get this in asap.
By: Joshua C. Colp (jcolp) 2006-04-18 09:43:42

Fixed in trunk, revision 21130. Thanks!