| Summary: | ASTERISK-06794: [patch] format_mp3 update | ||
| Reporter: | Roman Avramenko (roman_) | Labels: | |
| Date Opened: | 2006-04-17 09:26:20 | Date Closed: | 2006-06-30 21:27:21 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) format_mp3_3.patch | |
| Description: | format_mp3.c (addon package) update to build with latest SVN trunk. | ||
| Comments: | By: Joshua C. Colp (jcolp) 2006-04-17 12:27:38 I've tried this patch using latest asterisk trunk and latest asterisk addons. It failed to build. Can you see what's up with it? Thankies. By: Roman Avramenko (roman_) 2006-04-18 00:42:11 Could you please provide compiler output? By: Roman Avramenko (roman_) 2006-04-19 08:09:31 Modules format slighly changed, new patch attached. By: Clod Patry (junky) 2006-04-23 13:20:49 it now compiling. By: Serge Vecher (serge-v) 2006-05-08 11:47:46 roman, please fix up the patch with the following in mind: 1. Commented out code pieces should be removed completely. 2. Comments after code should line up. This is in: char waste[AST_FRIENDLY_OFFSET]; /* Buffer for sending frames, etc */ char empty; /* Empty character */ Thanks! By: Roman Avramenko (roman_) 2006-05-10 00:45:32 Fixed. By: Russell Bryant (russell) 2006-06-30 21:17:46 I have incorporated the changes from this patch into my asterisk-addons fixup branch. Everything applied and worked great. Thank you! http://svn.digium.com/svn/asterisk-addons/team/russell_fixup By: Russell Bryant (russell) 2006-06-30 21:27:21 This has now been merged into the trunk, thank you! | ||