|Summary:||ASTERISK-06782: [patch] No need to call ast_best_codec and ast_codec_choose when there is disallow=all in [general]|
|Reporter:||Andrey S Pankov (casper)||Labels:|
|Date Opened:||2006-04-13 22:09:26||Date Closed:||2006-06-05 10:26:44|
|Environment:||Attachments:||( 0) chan_sip.c.diff|
|Description:||Patch is uploaded.|
|Comments:||By: Serge Vecher (serge-v) 2006-05-08 14:53:51|
casper, what is the benefit of this patch?
By: Andrey S Pankov (casper) 2006-05-08 15:05:24
To avoid useless code execution... Nothing to add to the "Summary", sorry :)
By: Olle Johansson (oej) 2006-06-01 13:36:14
If you have disallow=all shouldn't we simply disable allowguest and just refuse all calls?
Is this a big issue that you use a lot?
By: Andrey S Pankov (casper) 2006-06-02 16:02:30
What do you mean?
As to disable allowguest for default setup I'd better have it disabled.
And yes, I always have disallow=all and configure codecs per peer.
By: Joshua C. Colp (jcolp) 2006-06-05 10:26:44
I'll be the bad guy here and decide that this is just a minor patch that won't really improve or add anything... so I'm declining it. Thanks anyway!