Summary:ASTERISK-06752: [post 1.4][patch] move ast_carefulwrite() to utils.h/.c because it is used by cli.c in ast_cli()
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2006-04-11 06:27:34Date Closed:2008-06-07 11:01:18
Versions:Frequency of
Environment:Attachments:( 0) 20060411_bug0006937.diff
( 1) cli.c.diff
( 2) utils.c.diff
( 3) utils.h.diff
Description:That will allow not to include manager.h in cli.c (utils.h is there)


The patch will follow... please wait a bit :)
Comments:By: Andrey S Pankov (casper) 2006-04-11 07:02:14

I do not upload patches for manager.c and manager.h since there are removals of the code only.

Please delete utils.h file, it's not needed.

By: BJ Weschke (bweschke) 2006-04-11 07:04:15

This is now a post 1.4 change as the door on timing has closed on architectural changes to /trunk.

By: Andrey S Pankov (casper) 2006-04-11 07:16:08

Can't agree with you. This is not architectural change at all. It's just an optimization. I understand that we are on "MONTHS 4 - 5" stage now, but...

"New features that are ready to be merged will still be accepted at this point."

And this is ready to be merged, isn't it?

Moreover, there will be a significant architectural change to modules infrastructure (by rizzo I guess).

By: BJ Weschke (bweschke) 2006-04-11 07:36:29

I want to remind everybody that we have our scheduled architectural
freeze, this Friday, for the 1.4 release.  What this means is that if
you have features that you would like to see in 1.4 THAT REQUIRE
CHANGES TO THE HEADER FILES, those changes need to be finalized
by this Friday.  We may push back the date by a couple days, if we have
enough on the bugtracker to discuss, but your patches on the bugtracker
must be applicable to the current trunk, and you must have addressed all
concerns listed on the bugtracker before Friday for your patch to be
considered for 1.4.

Features that do not require changes to the header files are not
architectural in nature; those features have until the beginning of May
to be gotten ready.


Moreover - the diffs you have up now don't include the removal of the same code you've put into utils.c from manager.c so this isn't ready to be merged as you'd be duplicating code.

I don't disagree with the idea for the change, but I'm only observing guidelines the rest of the group have already set.

By: Andrey S Pankov (casper) 2006-04-11 07:40:42

I expect there should be a sort of announce on -dev if you are really right about "the door on timing". The only post from Kevin on "Roadmap for 1.4" didn't mentioned about "the door" or similar.

By: Andrey S Pankov (casper) 2006-04-11 07:58:06

Uploaded complete 20060411_bug0006937.diff

I Forgot to mention about removal of manager.h in res_agi as well.

By: Andrey S Pankov (casper) 2006-04-12 09:45:17

Any feedback here? It's ready to be commited, isn't it?

By: Serge Vecher (serge-v) 2006-05-05 15:44:15

casper: I think that if you want to see this patch make it into the trunk, your best bet is to get on an #asterisk-dev channel or attend a developer call on Tuesday and convince a developer with commit access that this change is really necessary.


By: Russell Bryant (russell) 2006-05-05 16:02:29

added to the trunk in rev 25026, thanks!

By: Digium Subversion (svnbot) 2008-06-07 11:01:18

Repository: dahdi
Revision: 744

U   trunk/mec2.h

r744 | mattf | 2008-06-07 11:01:17 -0500 (Sat, 07 Jun 2008) | 2 lines

Small fixes for mec2 echo can from ASTERISK-6752