| Summary: | ASTERISK-06750: [patch] do not allow unlimited calls if app_dial is called with S(0) or L(0), or if there is an error in parsing limit values | ||
| Reporter: | Andrey S Pankov (casper) | Labels: | |
| Date Opened: | 2006-04-11 03:27:15 | Date Closed: | 2006-04-11 11:16:59 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_dial |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 2app_dial.c.diff ( 1) app_dial.c.diff | |
| Description: | - minor formatting cleanup and removal of trailing whitespace (sorry for that) - do not even try to play files with empty names (when LIMIT_*_FILE vars are set but empty) - be verbose when call duration limit is set with L(timelimit) - use pre-defined formatting for the 4th sublevel verbosity (current one is ugly) - no need in "UNDEF" - "(null)" is better and does not require additional checks ****** ADDITIONAL INFORMATION ****** If the patch is commited you may safely close http://bugs.digium.com/view.php?id=6838 Thanks! | ||
| Comments: | By: BJ Weschke (bweschke) 2006-04-11 10:42:46 casper: how about a LOG_WARNING or LOG_ERROR when timelimit and callduration is 0 and you're going to exit them from app_dial so they know what happened? By: Andrey S Pankov (casper) 2006-04-11 11:02:18 Fixed now. By: BJ Weschke (bweschke) 2006-04-11 11:16:59 Committed to /trunk. Thanks! | ||