Summary:ASTERISK-06729: [patch] Disable debug output when option_debug not set.
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2006-04-07 14:52:28Date Closed:2011-06-07 14:08:11
Versions:Frequency of
Environment:Attachments:( 0) 6chan_sip.c.diff
Description:Do not send debug output if not enabled.
Comments:By: Olle Johansson (oej) 2006-04-07 16:32:04

Please add proper summary headings to make it easier to prioritize bug reports/patches. Thanks.

By: Andrey S Pankov (casper) 2006-04-09 14:23:12

Rediffed again with 19128. (6chan_sip.c.diff)
The patch decreases in size... you've fixed the things already fixed.

By: Andrey S Pankov (casper) 2006-04-11 06:42:42

Why not to commit this to help your chan_sip cleanup efforts?..

By: Andrey S Pankov (casper) 2006-04-12 09:44:05

oej: If you do not plan to commit this, please close...

By: Serge Vecher (serge-v) 2006-05-05 16:27:44

casper: do you want to try to rediff again?

By: BJ Weschke (bweschke) 2006-05-05 16:44:50

casper: The current patch fails to apply. Pls give oej until after the dev conference next week (5/12) as he will be working on alot of changes (as he's said he will be) to incorporate SIP transfers, and then we'll give this one another shot. no point in either of you spinning cycles on patches that would ulimately compete against each other. Thanks.

By: Russell Bryant (russell) 2006-05-05 21:08:54

I'm going to go ahead and suspend this issue for now, since the patch will likely have to be redone after the major SIP changes that will likely happen in the next week.  Once that clears up, feel free to re-open this issue with an updated patch.  Thanks for your understanding!