Summary:	ASTERISK-06727: [branch][post 1.4] play agent num to caller in queue
Reporter:	Yunlong Liu (lyl)	Labels:
Date Opened:	2006-04-07 02:52:28	Date Closed:	2011-06-07 14:02:49
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) queue.patch.new
Description:	when set up a callcenter, sometimes it's better for caller to know who is servicing for, so I added a patch for this. ****** ADDITIONAL INFORMATION ******    something has to be added to queue.conf if you want to use this feature,  like this: [testqueue] ;last number is agent number, which must be de digital number member => Agent/2000,,1000 ;if to announce agent number, default to no announceagentnum = yes ;voice before saying agent number, default is "announceagentnum1", add ;a file in sounds directory announceagentnum1 = announceagentnum1 ;voice after saying agent number, default is "announceagentnum2", ; add to sounds directory too announceagentnum2 =announeagentnum2
Comments:	By: Yunlong Liu (lyl) 2006-04-07 03:43:17 this patch play agent num to caller when the agent pick up the handset By: BJ Weschke (bweschke) 2006-04-07 08:07:26 Hello. You need to have a disclaimer on file in order for your code to be considered and it must also be a patch against the /trunk version of the code as we don't add new features/functionality to 1.2. Please let us know if you'd be interested in reworking the patch and submitting a disclaimer and we'll help you through the process. By: Yunlong Liu (lyl) 2006-04-09 09:24:40 Oh, I see. I'll rework on it and post a patch for trunk the next day, thanks for your advice, bweschke. By: Yunlong Liu (lyl) 2006-04-10 01:48:07 The second patch is against trunk rev. 18692. By: BJ Weschke (bweschke) 2006-04-10 12:54:50 lyl: Thanks for your continuned interest in getting this feature merged with the Asterisk codebase! Do you have a disclaimer completed and on file yet? If so, we can now take a look at the patch. By: Yunlong Liu (lyl) 2006-04-10 19:59:53 I also want to have a disclaimer on the files, but I can't alter it. Can you help me? By: BJ Weschke (bweschke) 2006-04-10 21:56:36 did you fax/mail your disclaimer form into Digium? If so, I can change the value. By: Yunlong Liu (lyl) 2006-04-19 21:58:40 Sorry for late, I have faxed a disclaimer to digum By: Matt O'Gorman (mogorman) 2006-04-26 16:22:10 can you please format your code like the rest of the code 8 spaces do not equal one tab.  Otherwise from what i read it looks pretty good. Mog By: opsys (opsys) 2006-04-29 00:52:51 How does this work when I am not using the Agent Channel but defining the member in my queue, Or if I use AddQueueMember(SIP/polycom123) By: Serge Vecher (serge-v) 2006-05-22 11:21:54 lyl: can you please update the patch against the latest trunk (rev > 29000), please, so this can be considered for inclusion in 1.4? Thanks. By: Serge Vecher (serge-v) 2006-06-05 19:58:46 lyl: still need an updated patch here ... By: Serge Vecher (serge-v) 2006-09-27 13:30:52 lyl, or anybody else still interested in seeing this feature go into trunk, 1.6-track, needs to update the patch to trunk and fix the formatting as per CODING GUIDELINES. Thanks By: jmls (jmls) 2006-10-31 11:28:48.000-0600 can you update this patch for the latest svn trunk ? Thanks. By: Anthony LaMantia (alamantia) 2006-10-31 16:11:42.000-0600 i have been reworking this patch into my patch-branch with some coding style and functionality changes. located here. http://svn.digium.com/view/asterisk/team/anthonyl/patch-branch/ By: Anthony LaMantia (alamantia) 2006-10-31 16:13:09.000-0600 i have been reworking this patch into my patch-branch with some coding style and functionality changes. located here. http://svn.digium.com/view/asterisk/team/anthonyl/patch-branch/ By: Serge Vecher (serge-v) 2007-02-22 15:53:57.000-0600 not sure if the branch is getting the automerge updates -- can you please update the patch to the latest trunk? By: Russell Bryant (russell) 2007-04-04 13:22:44 BJ agreed on the bug conference call to give this patch a try.  I'm marking it as assigned pending his feedback. By: jmls (jmls) 2007-09-12 16:33:48 where did we get to with this patch ? By: Mark Michelson (mmichelson) 2008-02-13 14:26:54.000-0600 I am suspending this issue since there has been no new activity on it in months. If there is a desire to implement this, then this can either be re-opened or a new issue may be created.