Summary: | ASTERISK-06723: [patch] Added application MacroIfTime | ||
Reporter: | Philipp Dunkel (pdunkel) | Labels: | |
Date Opened: | 2006-04-06 17:55:41 | Date Closed: | 2011-06-07 14:03:12 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_macro |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) app_macro.c.patch | |
Description: | Just like GotoIfTime (actually I took the code from there) just for macros. I basically copied the code from GotoIfTime and executes macro_exec instead of Goto I work a lot with macros, and time dependent execution is quite useful. Of course this could also be done with x,1,GotoIfTime(<time>?3) x,2,Goto(4) x,3,Macro(macro) x,4,... But why not x,1,MacroIfTime(<time>?macro) shortens thing a bit and was an easy thing to do. | ||
Comments: | By: Tilghman Lesher (tilghman) 2006-04-06 19:32:49 What does this do that ExecIfTime doesn't already do? By: Philipp Dunkel (pdunkel) 2006-04-06 19:41:57 ExecIfTime executes a DialPlan Application while this executes a Macro. You coud Probably do ExecIfTime(<time>?Macro(<macro>)) as well This might just be bloat. I was just astonished that there is: Goto -> GotoIfTime Exec -> ExecIfTime Macro -> ??? It seemed logical that there should be a MacroIfTime. Whether it's worth it is really your call. As I said, it's not that essential an item. More of a consitency thing. I caught myself once to often just writing MacroIfTime and then rememberig that there isn't one. So I wrote it. As I said it might just be bloat. By: Tilghman Lesher (tilghman) 2006-04-06 19:48:27 Considering that we have both a Goto as well as an Exec, and that you can do exactly what you want here with an ExecIfTime, this is not a needed application. |