Summary:	ASTERISK-06674: [patch] Silent verboser, "unify" constructs, move some code from inside "if (option_verbose > x)" constructs
Reporter:	Andrey S Pankov (casper)	Labels:
Date Opened:	2006-03-31 11:39:52.000-0600	Date Closed:	2006-04-05 13:07:27
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_alarmreceiver.c.1.2.diff ( 1) app.c.diff ( 2) ast_verbose.diff ( 3) chan_1.2.diff ( 4) XXX.diff ( 5) XXXXX.diff
Description:	Please see the patch attached.
Comments:	By: Joshua C. Colp (jcolp) 2006-03-31 11:46:33.000-0600 Can you attach the patch so we can see it? ;) By: Andrey S Pankov (casper) 2006-03-31 11:55:53.000-0600 - chan_zap: manager_event DNDState was inside 'if (option_verbose > 2)' block - chan_iax: manager_event Registry was not sent whith option_verbose <=2 - app.c: patch not included (ask Corydon for details) - app_alarmreceiver: continue was inside 'if (option_verbose >= 2)' block - app_queue: multiple 'res = -1' inside option_verbose blocks (please look whether these assignments are needed there at all) - README: fix the name of security document (I don't understand why Corydon does not want to fix this) By: Andrey S Pankov (casper) 2006-03-31 12:05:08.000-0600 Please commit http://bugs.digium.com/view.php?id=6838 as well as an addition to this patch. And finally app.c.diff - nothing special there... By: Olle Johansson (oej) 2006-03-31 13:34:55.000-0600 Please don't combine a lot of different things into one big superpatch, try splitting it up to make the decision process easier. By: Olle Johansson (oej) 2006-03-31 13:46:54.000-0600 Fixed the README. Adding smaller patches makes it easier to go through and divide the workload between us committers. By: Andrey S Pankov (casper) 2006-03-31 13:58:40.000-0600 Rediffed against 16775 - silent verboser to match verbose level - unify 'if (option_verbose > x)' blocks - chan_zap: manager_event DNDState was inside 'if (option_verbose > 2)' block - chan_iax: manager_event Registry was not sent whith option_verbose <=2 - app_alarmreceiver: continue was inside 'if (option_verbose >= 2)' block - app_queue: multiple 'res = -1' inside option_verbose blocks (please look whether these assignments are needed there at all) By: Andrey S Pankov (casper) 2006-03-31 14:20:15.000-0600 Added chan_1.2.diff and app_alarmreceiver.c.1.2.diff for 1.2 branch. You'll need to block these fixes for trunk. I don't add app_queue fix since 'res = -1' may be safely ignored (don't break anything) IMO. By: Andrey S Pankov (casper) 2006-04-03 07:46:13 Close this with "won't fix" resolution if this is too hard to evaluate for commit... By: Andrey S Pankov (casper) 2006-04-04 14:18:23 XXX.diff rediffed against 17404: - silent verboser to match verbose level - unify 'if (option_verbose > x)' blocks - no other changes already in trunk filed separately as requested By: Andrey S Pankov (casper) 2006-04-05 12:25:59 Lost interest in this. Please close the bug. I hope http://bugs.digium.com/view.php?id=6889 is a better solution... By: Joshua C. Colp (jcolp) 2006-04-05 12:29:13 Closed because of a potential better solution on another bug (6889)