Summary:ASTERISK-06608: keyword ringcadance used in indications.conf is misspelt
Reporter:benjk (benjk)Labels:
Date Opened:2006-03-23 20:40:45.000-0600Date Closed:2011-06-07 14:08:15
Versions:Frequency of
Description:Asterisk's config reader only recognises the misspelt "ringcadance" in indications.conf. This should really be "ringcadence" as there is no such word as "cadance".

I realise that fixing this will break all the existing indications.conf files out there, but it is very easy to replace all occurences of "ringcadance" to "ringcadence" with a simple script, so this shouldn't really be a serious obstacle.

In any event I would appreciate to get some feedback on this as I am working on a conversion utility for Asterisk INI files and if there is consensus that the properly spelt keyword should be used in the future I would like to add it to my parser now while I am still working on it.
Comments:By: Russell Bryant (russell) 2006-03-24 08:56:34.000-0600

What line number is this?  I do not see "cadance" used in the sample indications.conf in either 1.2 or the trunk.

By: Russell Bryant (russell) 2006-03-24 09:16:29.000-0600

Both 1.2 and the trunk have the following line:

      } else if ((!strcasecmp(v->name,"ringcadence"))||(!strcasecmp(v->name,"ringcadance"))) {  

They support both.  I'm closing this as not an issue.