Summary:ASTERISK-06599: Verbose levels not enforced in app_voicemail
Reporter:flobi (flobi)Labels:
Date Opened:2006-03-22 13:48:42.000-0600Date Closed:2008-01-15 17:48:40.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_voicemail.patch
Description:There are many instances in app_voicemail where messages are created, but not filtered for the assigned verbosity.  For instance, a line like this:

ast_verbose(VERBOSE_PREFIX_3 "Blah blah\n");

lacks any preceeding if statement, e.g.:

if (option_verbose > 2) ast_verbose(VERBOSE_PREFIX_3 "Blah blah\n");
Comments:By: Joshua C. Colp (jcolp) 2006-03-22 14:07:48.000-0600

If you wish to provide a patch to correct these then you may, otherwise this isn't a bug. Feel free to try to convince me otherwise or provide a patch ;) Thanks for the bug note though and have a great day.

By: flobi (flobi) 2006-03-22 14:44:34.000-0600

Okay, I've got a patch.

By: flobi (flobi) 2006-03-22 14:46:07.000-0600

I uploaded it.  I've not done this before, but I followed the directions I think well; let me know if I have done it incorrectly.

By: Joshua C. Colp (jcolp) 2006-03-22 14:49:56.000-0600

Traditionally when we do if statements like this for verbosity, then we put the ast_verbose function call on the next line, and indent it over. If you can do this quickly I can take care of this and get it commited. Thankies!

By: Joshua C. Colp (jcolp) 2006-03-22 16:28:59.000-0600

This has been commited to both 1.2 and trunk, merci (thanks)!

By: Joshua C. Colp (jcolp) 2006-03-22 16:34:29.000-0600

I'd like to note that while you don't have a disclaimer on file, I still modified the stuff from scratch and changed it to conform to our standards and to get rid of a compiler error... but please in the future submit a disclaimer.

By: Digium Subversion (svnbot) 2008-01-15 17:48:38.000-0600

Repository: asterisk
Revision: 14275

U   branches/1.2/apps/app_voicemail.c

r14275 | file | 2008-01-15 17:48:38 -0600 (Tue, 15 Jan 2008) | 2 lines

Issue ASTERISK-6599 - Verbose levels not enforced in app_voicemail (Reported by flobi)



By: Digium Subversion (svnbot) 2008-01-15 17:48:40.000-0600

Repository: asterisk
Revision: 14277

_U  trunk/
U   trunk/apps/app_voicemail.c

r14277 | file | 2008-01-15 17:48:40 -0600 (Tue, 15 Jan 2008) | 10 lines

Merged revisions 14275 via svnmerge from

r14275 | file | 2006-03-22 18:13:30 -0400 (Wed, 22 Mar 2006) | 2 lines

Issue ASTERISK-6599 - Verbose levels not enforced in app_voicemail (Reported by flobi)