[Home]

Summary:ASTERISK-06584: [patch] configurable timeout for Attended Transfer
Reporter:Miroslav Nachev (mnachev)Labels:
Date Opened:2006-03-21 03:09:51.000-0600Date Closed:2006-05-23 13:23:22
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_features.patch
Description:It is very useful to configure the timeout for attended transfer instead to be fixed to 15 seconds. We do that ourself and would like this patch to be included in the next release.

****** ADDITIONAL INFORMATION ******

In the standard source code of function builtin_atxfer(...) is writen:
  newchan = ast_feature_request_and_dial(
     transferer, "Local",
     ast_best_codec(transferer->nativeformats),
                    dialstr,
                    15000,
                    &outstate, cid_num, cid_name);
We replace this line with this one:
  newchan = ast_feature_request_and_dial(
     transferer, "Local",
     ast_best_codec(transferer->nativeformats),
                    dialstr,
                    atxfernoanswertimeout,
                    &outstate, cid_num, cid_name);

where "atxfernoanswertimeout" is static int which can be configured in features.conf. the default value is 15000.
Comments:By: Russell Bryant (russell) 2006-03-21 08:51:42.000-0600

Please submit your changes in "svn diff" format.  Also, we will need a disclaimer from you to consider using your code.
By: Miroslav Nachev (mnachev) 2006-03-22 07:28:22.000-0600

The patch in "svn diff" format is attached.
By: Russell Bryant (russell) 2006-03-28 12:29:10.000-0600

disclaimer?
By: Miroslav Nachev (mnachev) 2006-03-28 12:45:18.000-0600

What have I do to disclaimer from my code?
I am agree the code to be used for Asterisk Open Source Community.
By: Russell Bryant (russell) 2006-03-28 13:20:40.000-0600

Instructions are available at the bottom of the main page:

http://bugs.digium.com/main_page.php
By: Serge Vecher (serge-v) 2006-05-03 12:18:54

mnachev: have you filed the disclaimer?
By: Miroslav Nachev (mnachev) 2006-05-03 14:59:06

I filled and sent the disclaimer before a months.
By: Serge Vecher (serge-v) 2006-05-03 15:03:52

ok, thank you for confirming that.

1. I've quickly looked at your patch and it seems to have formatting problems in if { else } constructs. Please review the CODING-GUIDELINES document and redo your patch according to those. Same goes for 'credit' comments -- no need to make those part of the patch, they are added later to the CREDIT file.

Thanks.


By: Matt O'Gorman (mogorman) 2006-05-23 13:23:22

Committed revision 29766.