Summary:	ASTERISK-06578: Changing the event flag of Newexten AMI event.
Reporter:	Gerhard Venter (gventer)	Labels:
Date Opened:	2006-03-20 19:16:04.000-0600	Date Closed:	2011-06-07 14:10:21
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/ManagerInterface
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	Currently the event flag for the "Newexten event" is set to EVENT_FLAG_CALL. It generates a lot of events that are not always needed, especially with big and complex dialplans. I was trying to turn it off to minimize the events send but there is no way since it is the same flag used for "real call" events. I suggest we create another event flag called EVENT_FLAG_DIALPLAN or EVENT_FLAG_EXTEN and replace it wiht this so we can seperate it from the real call events and subsribe to it seperatly. Does it make sense? ****** ADDITIONAL INFORMATION ****** It is only located in 2 places. "pbx.c" and "pbx realtime.c" : manager_event(EVENT_FLAG_CALL, "Newexten", "Channel: %s\r\n" "Context: %s\r\n" "Extension: %s\r\n" "Priority: %d\r\n" "Application: %s\r\n" "AppData: %s\r\n" "Uniqueid: %s\r\n", c->name, c->context, c->exten, c->priority, app->name, passdata ? passdata : "(NULL)", c->uniqueid); We would also have to add it to to manager.c : static struct permalias { int num; char *label; } perms[] = { { EVENT_FLAG_SYSTEM, "system" }, { EVENT_FLAG_CALL, "call" }, { EVENT_FLAG_LOG, "log" }, { EVENT_FLAG_VERBOSE, "verbose" }, { EVENT_FLAG_COMMAND, "command" }, { EVENT_FLAG_AGENT, "agent" }, { EVENT_FLAG_USER, "user" }, { -1, "all" }, { 0, "none" }, };
Comments:	By: BJ Weschke (bweschke) 2006-03-22 13:32:20.000-0600 gventer: you may get a better response to your proposal by bringing it up in the asterisk-dev forum. By: Gerhard Venter (gventer) 2006-03-22 15:41:52.000-0600 I don't think so - I never get any repsonses there - it seems useless. I never see any of the Digium guys posting or repsonding there. Hence I logegd it here. :) The AMI is good but there is room for improvement. I am just not a C programmer otherwise I would have been doing a lot of proposed patches. By: Gerhard Venter (gventer) 2006-04-27 15:08:35 Anybody thinking this will be useful? By: Serge Vecher (serge-v) 2006-05-04 15:50:50 never hurts to try -- you don't seem to be getting more response here ... By: Gerhard Venter (gventer) 2006-05-05 10:12:05 Well that is a very constructive answer! Thanks. I yet have to see any good answer from you, all I see is you closing issues and ask feedback. Thats about it - now that worries me. I think the suggestion is straight forward, what feedback are you looking for, confirmation? By: Serge Vecher (serge-v) 2006-05-05 10:52:03 >I yet have to see any good answer from you, all I see is you closing issues and ask feedback. Thats about it - now that worries me. I am not sure what you mean by good answers. At the moment, bug tracker needs some management and that's the way I chose to contribute my time to the project: closing bugs that are not, asking people for debugging information where it is missing and testing patches. >I think the suggestion is straight forward, what feedback are you looking for, confirmation? In this particular bug, I'm not looking for feedback or confirmation, if you read my note. I've merely suggested that you follow bweschke's suggestion to email the asterisk-dev list. I'm sorry if you find this unhelpful. I will mind my own business in relation to this issue. By: Gerhard Venter (gventer) 2006-05-05 11:31:35 I dont understand then. If you are not looking for feedback why did you change the status from new to feedback? Can you tell me why this issue will be solved in the dev forums rather than in the issue tracker? I fail to see the reason because the dev forums are more related to specific develepment problems using the existing code base. Here I have suggested a change in the code base so that is why I logged it here. I really dont want to get into an argument with you but you have to explain to me why this is not an issue for issue tracker. >I'm sorry if you find this unhelpful. I will mind my own business in relation to this issue. Please dont be like this. >never hurts to try -- you don't seem to be getting more response here ... Have you read the suggestion? If you are an issue tracker then please let me know what is wrong, why it doesnt belong here other than tell me to look for an answer elsewhere. This is an serious issue for me as it generates a lot of events that I am really not interested in and there is no way to filter it out. Yes I filter it out on my end but I would prefer if I can prevent it from being send in the first place. By: Joshua C. Colp (jcolp) 2006-05-05 11:52:22 These people are urging you to try elsewhere because no feedback has been received thus far from people on here. It's been here two months and nobody has really said, "hey! I'd like this too!". By: Gerhard Venter (gventer) 2006-05-05 12:09:21 Thank you Josh. Mithraen has monitor the issue so I would assume he/she is interested in it as well. Anyway I will add it to the dev forum as well. By: Serge Vecher (serge-v) 2006-05-19 13:54:49 Please feel free to reopen the issue, when the consesus is reached on asterisk-dev list and a patch is available. Thank you.