[Home]

Summary:ASTERISK-06559: [patch] Compile warnings from ast_expr2.y on MacOS X
Reporter:Thorsten Lockert (tholo)Labels:
Date Opened:2006-03-16 13:32:46.000-0600Date Closed:2008-01-15 17:34:27.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) expr2.diff
Description:ast_expr2.y will unconditionally try to define QUAD_MIN if LONG_LONG_MIN is defined, and QUAD_MAX if LONG_LONG_MAX is defined.

****** ADDITIONAL INFORMATION ******

The enclosed patch will further protect against redefinition by encapsulating in '#ifndef QUAD_MIN' and '#ifndef QUAD_MAX' sequences.
Comments:By: Olle Johansson (oej) 2006-03-16 14:10:19.000-0600

Hmm. My Bison can't create a new ast_expr2.c from the patched file.
By: Russell Bryant (russell) 2006-03-16 14:12:41.000-0600

I have added this to the trunk in revision 13280.  I decided not to make this change because I didn't want to have to regenerate ast_expr2.c in the release branch just to suppress a warning.

Thanks!
By: Russell Bryant (russell) 2006-03-16 14:13:11.000-0600

oej: If you are using the default bison that comes with mac, you have to update because it is too old.
By: Tilghman Lesher (tilghman) 2006-03-16 14:18:08.000-0600

Fixed on 1.2, as well.
By: Digium Subversion (svnbot) 2008-01-15 17:33:55.000-0600

Repository: asterisk
Revision: 13280

U   trunk/ast_expr2.c
U   trunk/ast_expr2.h
U   trunk/ast_expr2.y

------------------------------------------------------------------------
r13280 | russell | 2008-01-15 17:33:55 -0600 (Tue, 15 Jan 2008) | 2 lines

fix compiler warning on mac (issue ASTERISK-6559)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=13280
By: Digium Subversion (svnbot) 2008-01-15 17:34:27.000-0600

Repository: asterisk
Revision: 13319

_U  team/murf/AEL2/
U   team/murf/AEL2/ast_expr2.c
U   team/murf/AEL2/ast_expr2.h
U   team/murf/AEL2/ast_expr2.y

------------------------------------------------------------------------
r13319 | murf | 2008-01-15 17:34:26 -0600 (Tue, 15 Jan 2008) | 23 lines

Merged revisions 13280-13281 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r13280 | russell | 2006-03-16 13:11:05 -0700 (Thu, 16 Mar 2006) | 2 lines

fix compiler warning on mac (issue ASTERISK-6559)

................
r13281 | tilghman | 2006-03-16 13:16:56 -0700 (Thu, 16 Mar 2006) | 10 lines

Merged revisions 13279 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r13279 | tilghman | 2006-03-16 14:05:00 -0600 (Thu, 16 Mar 2006) | 2 lines

Bug 6737 - Fix compile warning on OS X

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=13319