|Summary:||ASTERISK-06554: [patch] app_meetme Muting and Manager API enhancements|
|Reporter:||Tony Mountifield (softins)||Labels:|
|Date Opened:||2006-03-15 09:35:54.000-0600||Date Closed:||2006-05-23 11:41:04|
|Environment:||Attachments:||( 0) app_meetme.c-1.2-muting.patch|
( 1) app_meetme.c-trunk-muting.patch
( 2) app_meetme.c-trunk-muting-27153.patch
( 3) app_meetme.c-trunk-muting-v2.patch
|Description:||The attached patches for trunk and 1.2 provide the following enhancements to MeetMe:|
1. Muting and unmuting is now done in one place in the main loop. Users' mute/unmute requests now just set a flag instead of doing the actual mute. Some of the old logic was not quite right anyway.
2. Mute and Unmute events are now reported via the Manager API.
3. Native Manager API commands MeetMeMute and MeetMeUnmute are provided, which are easier to use than "Action Command:".
4. The 'm' option (monitor) is renamed to 'l' (listen only), and the 'm' option now provides the functionality of "initially muted". In practice, most existing dialplans using the 'm' flag should not notice any difference, unless the keypad menu is enabled, allowing the user to unmute themsleves.
5. An extra facility is added to the keypad menu: * sends a MeetMeAlert manager event and plays the sound file "conf-sysopreq" (available from asterisk-sounds).
I'm assuming these changes, if approved, would only get committed into trunk, but I've included a patch for 1.2, for anyone who wants to use these features with 1.2 (as I do).
|Comments:||By: Olle Johansson (oej) 2006-03-18 04:09:48.000-0600|
Cool stuff. Should ASTERISK-1 be configurable? Not every installation has a sysop and playing the file by default would just make people expect action when there is noone to respond.
Personally I would rather have one event "MeetMeMuteStatus" or something, with a status field saying whether the user is muted or not. The same goes for the action. One action to enable/disable muting.
Guessing we at some point need to change the talking event to follow the same syntax :-)
I also feel that including caller id num and name in the mutestatus events would help an app, like an interface to IRC or Jabber.
By: Tony Mountifield (softins) 2006-03-21 03:42:23.000-0600
Yes, Olle, I think I agree with you about ASTERISK-1. Perhaps that should be treated separately from the muting changes, and be subject to an option argument.
I'm not so sure about your "MeetMeMuteStatus" suggestion. As you say, the talking event doesn't follow that pattern. Also, we have MeetMeJoin and MeetMeLeave, rather than one MeetMePresence event :-)
I can certainly include CallerID num and name in the event. I see the trunk already has them in MeetmeLeave (but not in the other, for some reason).
Stand by for an updated patch in the next day or so....
By: BJ Weschke (bweschke) 2006-05-08 09:56:50
softins: I just saw the Mute / Unmute manager events got added to /trunk with something else. Do you want to rework the patch to include appropriate commands and I'll try and get it in to /trunk. Thanks.
By: Tony Mountifield (softins) 2006-05-08 16:51:59
Yes, I'll do that. It'll be a day or two till I have the time, but I'll make sure it's done this week.
I'll remove item 5 and leave that for a separate feature.
By: Tony Mountifield (softins) 2006-05-11 11:01:46
OK, I've uploaded a v2 patch for trunk, based on revision 26250.
This patch omits feature ASTERISK-1 (sysop alert). It uses a single event MeetMeMute with Status: off or Status: on. I also updated the MeetMeTalking event to the same standard.
This supersedes the events that were added recently from bug 6811, so I removed those, and also tidied up some of the surrounding code while I was there.
Hope this is all ok!
By: Tony Mountifield (softins) 2006-05-17 02:18:06
I see app_meetme.c was updated in trunk yesterday to revision 27153. I've uploaded a new patch, which applies to this revision.
Hopefully this will make it into trunk before too long...
By: Stefan Reuter (srt) 2006-05-22 21:40:23
This patch is a really useful extension for app_meetme!
What are the issues that prevent if from being commited for 2 months?
By: Tony Mountifield (softins) 2006-05-23 02:04:22
To be fair, most of that time was due to my delay in responding to the bug marshalls' comments on my initial patch. BJ Weschke gave me a prod on 8th May to get things moving again.
By: Stefan Reuter (srt) 2006-05-23 02:14:30
I didn't want to blame anybody :)
So far this patch has worked fine for me - just curious if there are issues left.
If yes maybe I can help...
By: BJ Weschke (bweschke) 2006-05-23 07:33:53
Tony - You're on my radar screen to get this done today. Sorry for the delays. BJ
By: BJ Weschke (bweschke) 2006-05-23 11:40:22
Committed to /trunk. Thanks!
By: BJ Weschke (bweschke) 2006-05-23 11:41:03
#1 - 4 Committed to /trunk.