[Home]

Summary:ASTERISK-06551: On SIP subscribe for the call completion function Asterisk returns a "489 Bad Event"
Reporter:Daniela Garling (daniela)Labels:
Date Opened:2006-03-15 05:34:35.000-0600Date Closed:2008-01-15 17:30:09.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Subscriptions
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:On SIP subscribe for the call-completion function Asterisk returns a "489 Bad Event" - this is because the "event" in the SIP header is not just "dialog", but also has a purpose.

SIP trace:
Event: dialog;purpose=call-completion
Accept: application/dialog-info+xml

A quick and dirty fix (it's better not to use strtok, but I'm not a good
c-programmer):

in channels/chan_sip.c
- if (!strcmp(event, "presence") || !strcmp(event, "dialog")) { /* Presence, RFC 3842 */
+ if (!strcmp(event, "presence") || !strcmp(strtok(event,";"), "dialog")) { /* Presence, RFC 3842 */


****** ADDITIONAL INFORMATION ******

Version: 1.2.4-BRIstuffed-0.3.0-PRE-1k
Comments:By: Olle Johansson (oej) 2006-03-15 06:20:29.000-0600

Please attach a SIP debug from the device so I can see the packet causing this error message. Thank you.
By: Olle Johansson (oej) 2006-03-15 06:21:01.000-0600

And also please tell us what kind of UA that sends this... :-)
By: Olle Johansson (oej) 2006-03-15 07:09:18.000-0600

Committed fix to revision 13026 of 1.2 and rev 13027 of trunk. Thanks for reporting this.
By: Digium Subversion (svnbot) 2008-01-15 17:30:09.000-0600

Repository: asterisk
Revision: 13026

U   branches/1.2/channels/chan_sip.c

------------------------------------------------------------------------
r13026 | oej | 2008-01-15 17:30:09 -0600 (Tue, 15 Jan 2008) | 2 lines

Issue ASTERISK-6551: Remove parameters to Event: header on SUBSCRIBE requests

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=13026