|Summary:||ASTERISK-06531: [patch] missing endif in codecs/gsm/Makefile|
|Reporter:||Luigi Rizzo (rizzo)||Labels:|
|Date Opened:||2006-03-12 16:33:52.000-0600||Date Closed:||2006-03-12 23:24:41.000-0600|
|Environment:||Attachments:||( 0) gsm.mak.diff|
|Description:||rev 12610 of codecs/gsm/Makefile adds two ifneq without the matching|
All these nested if are very hard to read, i suggest to
replace them with the attached patch which uses findstring
to match the desired strings instead of using many ifneq.
It would be even better if in this specific case we would
use positive logic instead of negative one to identify the
cases where we do want the optimized code, but i have no
idea on which uname/PROC to use to identify that case.
NOTA BENE: the whitespace in the arguments of the findstring is
significant. Do not remove it, and do not remove the comment
about it, or mainteinance of this file becomes a lot harder.
|Comments:||By: Tilghman Lesher (tilghman) 2006-03-12 23:24:41.000-0600|
Committed to trunk. Thank you.