Summary:ASTERISK-06487: [patch][post 1.4] Re-introduce GSM codec capability support for chan_h323
Reporter:Paul Cadach (pcadach)Labels:
Date Opened:2006-03-06 14:12:40.000-0600Date Closed:2006-08-30 11:34:47
Versions:Frequency of
Environment:Attachments:( 0) h323-gsm.diff
( 1) h323-gsm-v2.diff
Description:GSM is moved out from main OpenH323 source tree into "plugins" so static definition of GSM capability is not available. This patch provides "local" variance of GSM capability to make chan_h323 independed of GSM from OpenH323 stack.
Comments:By: Serge Vecher (serge-v) 2006-05-01 15:28:10

casper: since you are involved in other chan_h323 work, could you please review this patch? Thanks.

By: Andrey S Pankov (casper) 2006-05-01 16:16:37

Am I involved? ;)

The path lacks my review for now because chan_h323 does not have a maintainer
(or it seems to have him, but it really doesn't).

Other thing is that I can't test the patch not owing any gsm hardware for
the moment.

By: Andrey S Pankov (casper) 2006-05-01 16:19:41

Code review: PASSED.
Not tried to compile but it seems to be OK.
Ready to be commited to trunk if there is any volunteers.

PCadach: can you confirm this does compile?

By: jerjer (jerjer) 2006-05-01 16:20:53

If you keep accusing me of not supporting chan_h323 I will simply pull my disclaimer and delete it from the svn tree.

By: Andrey S Pankov (casper) 2006-05-01 16:26:58

Dear Jeremy,

Please demonstrate us that you do maintain it.
How about to commit fixes already in the bugtracker?
That's all I ask you about. We'd be very happy...
and me personally of course.


By: jerjer (jerjer) 2006-05-01 16:31:42

I am not going to jump because you told me to. This is not the way to motivate someone.  When my free time allows me to setup a machine with H.323 support i will glady commit changes - ONLY AFTER I AM POSITIVE IT WILL COMPILE.

OSHA only allows 3 people on my ass unless I install handrails and safety belts - Get off my ass.

By: Bluce Ree (tasker) 2006-05-03 13:55:51

I have a patch that will install the hand-rails and safety belts required by JerJer to increase capacity on his ass. Does it also require the same type of disclaimer faxed to Digium?

By: Andrey S Pankov (casper) 2006-05-04 12:00:45

tasker: that's for asterisk-flames, not the bugtracker... but I like your way :)

By: Andrey S Pankov (casper) 2006-05-04 16:41:37

And yes, it compiles... :)

By: Serge Vecher (serge-v) 2006-07-06 12:43:16

need functional tests for this patch.

By: Paul Cadach (pcadach) 2006-08-30 11:34:47

Merged into chan_h323-live branch.