Summary:ASTERISK-06470: [patch] Compiling editline/term.c on Solaris generates several warnings
Reporter:drach (drach)Labels:
Date Opened:2006-03-03 13:31:11.000-0600Date Closed:2006-03-20 23:31:02.000-0600
Versions:Frequency of
Environment:Attachments:( 0) 20060311__bug6646__2.diff.txt
( 1) term.c.patch
Description:Solaris /usr/include/term.h can't be included in term.c because of several incompatibilities.  As a consequence, several missing prototype warnings are generated during the compile.  This patch declares the prototypes.  It also changes #include <term.h> to #include "term.h" to be more explicit about which term.h is actually included.
Comments:By: silik0n (silik0n) 2006-03-10 23:04:22.000-0600

I'm seeing several problems trying to compile on Sol10, Sparc w/ GCC 3.3.2 and gmake 3.80 (lastest versions with pkg-get)

can you contact me on freenode or via email? SwK or krice@suspicious.org

By: Tilghman Lesher (tilghman) 2006-03-11 07:46:24.000-0600

We actually DO want the systemwide term.h here, so I've made a correction to your patch that works on Linux.  Please test to make sure it works on Solaris.

By: Tilghman Lesher (tilghman) 2006-03-11 08:12:29.000-0600

Okay, maybe we don't want the system-wide one.  In any case, those missing prototypes also existed on Linux, so let's solve the problem for both platforms.  Again, please test.

By: silik0n (silik0n) 2006-03-20 22:13:27.000-0600

Corydon76's patch fixes the problem gcc version 3.4.3 (csl-sol210-3_4-branch+sol_rpath)   which now ships with sol10.

can we get a review on this and possibly get it commited?

By: Tilghman Lesher (tilghman) 2006-03-20 23:31:02.000-0600

Committed to 1.2, merged to trunk.