Summary:ASTERISK-06425: [patch] Integration with ZIM-SMS (www.zim.biz)
Reporter:Wojtek (virterm)Labels:
Date Opened:2006-02-26 09:51:43.000-0600Date Closed:2006-03-16 14:22:02.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_voicemail.c.patch
( 1) app_zim_sms.c
( 2) INSTALL.current
( 3) Makefile.patch
( 4) modules.conf.patch
( 6) zim-sms.conf
( 7) zim-sms.h
Description:Package contains application allowing sending SMS directly from dialplan. Also, patch for current voicemail is included to allow sending voicemail notification through ZIM. Installation instruction included as well.

****** STEPS TO REPRODUCE ******



If this is not correct way to sumbit new apps, please instruct me :)
Comments:By: Wojtek (virterm) 2006-02-26 10:07:46.000-0600

Please note that zim-sms-asterisk-1.1.4.tar.gz also contains versions for 1.0 and 1.2 (up to 1.2.4) version fo Asterisk. Seperate files applied to current.

By: Russell Bryant (russell) 2006-02-26 18:14:23.000-0600

1) New features are only added to the development branch, so the code will have to be updated to the svn trunk

2) We will need a disclaimer on file before anyone can review your code.  You can find more information on the main page of bugs.digium.com.


By: Wojtek (virterm) 2006-02-27 06:53:17.000-0600

Ok, The disclaimer is on file now.

By: Wojtek (virterm) 2006-02-27 09:36:19.000-0600

Ok, I have a version which fully integrates with current trunk. How do I replace files with the new version? Should I just create another "issue".

By: Russell Bryant (russell) 2006-02-27 09:40:52.000-0600

You can upload the new files here.  I will delete all of the files that you have here now so that you don't have to change the names or anything.

By: Wojtek (virterm) 2006-02-27 09:51:35.000-0600

Ok, all done. I've added a flag to enable or disable support for voicemail notifications.

By: Matt O'Gorman (mogorman) 2006-02-28 15:35:49.000-0600

Hi I hate to be the naysayer , but is there any reason for this to really go into the tree?  It is not generic to sms providers , and only really applicable to zim sms.  Also the things it does could be performed by func_curl, and the extern_notify feature of voicemail.  I think that this should probably be maintained by zim_sms and see no real reason for its addition to the tree.  Please feel free to comment.

By: Tilghman Lesher (tilghman) 2006-02-28 23:43:48.000-0600

I agree.  If anything, it should go towards -addons, not into the main tree.

By: Olle Johansson (oej) 2006-03-02 14:19:33.000-0600

Do we need a generic API for sending SMS instead of all these various addons/applications?

By: Wojtek (virterm) 2006-03-02 15:21:53.000-0600

Would SMPP support make sense? That would be generic but limited in most cases to large volume of traffic.

By: Tilghman Lesher (tilghman) 2006-03-16 14:22:02.000-0600

If you want to contribute a generic SMPP implementation, I don't see any problem with that.  Let's close this one out and submit a future SMPP patch under a new bug number, when it's ready.