| Summary: | ASTERISK-06365: [patch] starting to using off_t type and fseeko/ftello | ||
| Reporter: | Denis Smirnov (mithraen) | Labels: | |
| Date Opened: | 2006-02-19 04:43:18.000-0600 | Date Closed: | 2006-02-19 14:36:34.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk.64bit.patch | |
| Description: | Using fseeko instead of fseek has'n any negative side effects. ftello can by used anywhere, if it's result not converted to int/long types. I think that we need convert all code to use fseeko/ftello/off_t, before using _FILE_OFFSET_BITS 64 This patch fix all format_*, file.c and file.h This patch consists of many oneliners and trivial fixes and don't need to be disclaimed. | ||
| Comments: | By: Denis Smirnov (mithraen) 2006-02-19 11:46:18.000-0600 This bug related, but not same. Yes, fixing that fixes bug with Monitor, but it other, bigger problem -- with formats, with logfiles, etc. Ahy ypu add negative karma? By: Tilghman Lesher (tilghman) 2006-02-19 11:58:12.000-0600 This patch is a significant duplicate of the patch in that bug. By: Denis Smirnov (mithraen) 2006-02-19 14:02:16.000-0600 This patches writed for different purposes. My patch only converts all ftell/fseek to fetllo/fseeko and must needed types to off_t. This task done _better_ with my patch. And I don't change _FILE_OFFSET. And I think that this task _must_ be in separate bug, because: not fix Monitor issue, that you links. | ||