Summary:	ASTERISK-06348: [patch] Called party wrongly transfered to priority+1 when G() option used with Dial
Reporter:	Dinesh Nair (alphaque)	Labels:
Date Opened:	2006-02-17 03:46:24.000-0600	Date Closed:	2008-01-15 17:38:16.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_dial
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_dial.c.diff ( 1) app_dial.c.diff2
Description:	with a dialplan like the following, exten => 55,1,DBget(PHONE2=demo/phone2) exten => 55,2,Playback(/recordings/prompt01) exten => 55,3,Dial(${PHONE2},,rG(from-internal-custom,55,4)) exten => 55,4,Playback(/recordings/prompt02) exten => 55,5,Playback(/recordings/prompt04) exten => 55,105,Hangup() the calling party is transferred to priority 4 while the called party is transferred to priority 5. this is inconsistent with the Dial helpfile which says, "If the call is answered, transfer both parties to the specified priority.". The attached patch fixes this and makes both parties get transferred to the same priority. ****** ADDITIONAL INFORMATION ****** Exists in 1.2.*, may exist in SVN as well.
Comments:	By: Dinesh Nair (alphaque) 2006-02-17 07:09:54.000-0600 i've added another file, app_dial.c.diff2, which instead of making the change prescribed above, amends the helptext/description of the Dial command to reflect what is actually being done. to repeat, applying app_dial.c.diff would make both legs go to the same priority while applying app_dial.c.diff2 would retain existing functionality but amends the helptext to be more accurate. i leave it to the good folk at digium/bug marshalls to decide on which is the more appropriate change to make. By: Russell Bryant (russell) 2006-03-14 12:43:39.000-0600 fixed in the 1.2 branch and the trunk in revisions 12927 and 12928, thanks! By: Russell Bryant (russell) 2006-03-14 12:44:13.000-0600 Also, I fixed the problem instead of updating the documentation to reflect the problem By: Russell Bryant (russell) 2006-03-19 03:57:12.000-0600 I have reverted this change in favor of keeping the existing behavior, as some people find it useful.  The other patch which updates the documentation to reflect the behavior has now been applied. By: Digium Subversion (svnbot) 2008-01-15 17:28:41.000-0600 Repository: asterisk Revision: 12927 U   branches/1.2/apps/app_dial.c ------------------------------------------------------------------------ r12927 | russell | 2008-01-15 17:28:41 -0600 (Tue, 15 Jan 2008) | 3 lines when using the G() option to Dial, fix sending the called channel to 1 priority beyond what was specified (issue ASTERISK-6348) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=12927 By: Digium Subversion (svnbot) 2008-01-15 17:28:42.000-0600 Repository: asterisk Revision: 12928 _U  trunk/ U   trunk/apps/app_dial.c ------------------------------------------------------------------------ r12928 | russell | 2008-01-15 17:28:42 -0600 (Tue, 15 Jan 2008) | 11 lines Merged revisions 12927 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r12927 | russell | 2006-03-14 13:41:05 -0500 (Tue, 14 Mar 2006) | 3 lines when using the G() option to Dial, fix sending the called channel to 1 priority beyond what was specified (issue ASTERISK-6348) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=12928 By: Digium Subversion (svnbot) 2008-01-15 17:37:39.000-0600 Repository: asterisk Revision: 13550 U   branches/1.2/apps/app_dial.c ------------------------------------------------------------------------ r13550 | russell | 2008-01-15 17:37:39 -0600 (Tue, 15 Jan 2008) | 4 lines revert the change made in revision 12927 in favor of keeping the original behavior of the option.  The documentation has now been updated to reflect the actual behavior.  (issue ASTERISK-6348) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=13550 By: Digium Subversion (svnbot) 2008-01-15 17:38:16.000-0600 Repository: asterisk Revision: 13587 _U  trunk/ U   trunk/apps/app_dial.c ------------------------------------------------------------------------ r13587 | russell | 2008-01-15 17:38:16 -0600 (Tue, 15 Jan 2008) | 12 lines Merged revisions 13550 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r13550 | russell | 2006-03-19 04:59:55 -0500 (Sun, 19 Mar 2006) | 4 lines revert the change made in revision 12927 in favor of keeping the original behavior of the option.  The documentation has now been updated to reflect the actual behavior.  (issue ASTERISK-6348) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=13587