[Home]

Summary:ASTERISK-06345: [patch][post 1.4] add context filter in "zap show channels"
Reporter:Edwin Groothuis (mavetju)Labels:
Date Opened:2006-02-16 22:53:45.000-0600Date Closed:2007-03-27 19:16:23
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch-channels::chan_zap.c
Description:When you have a lot of zap channels (two quad PRI cards with E1s on them for example, good for 248 channels), the output of "zap show channels" is euhm... too big to handle.

This patch adds a filter so that it only displays a certain context and not the other ones. It also adds the trunkgroup filter to the usage of "zap show channels"
Comments:By: Olle Johansson (oej) 2006-03-04 05:37:31.000-0600

All new features are only implemented in svn trunk. Can you please upload a patch for current svn trunk? Thank you.

By: Edwin Groothuis (mavetju) 2006-04-01 05:38:27.000-0600

The new file patch-channels::chan_zap.c is against HEAD as requested.

By: Leif Madsen (lmadsen) 2006-05-03 13:35:24

Would it be possible to get this updated to the latest trunk? It looks like a relatively small change.

By: Serge Vecher (serge-v) 2006-06-06 12:56:58

yes: please do update. This has two hunks failing when I try to apply it to the latest chan_zap.c.

Thanks

By: Serge Vecher (serge-v) 2006-09-27 13:33:48

mavetju: still need an update to trunk ...

By: jmls (jmls) 2006-11-01 12:39:09.000-0600

mavetju: can we have an updated patch for trunk, please. Thanks

By: jmls (jmls) 2007-01-07 03:17:55.000-0600

mavetju: are you able to provide a new patch, or should we close this ? Thanks.

By: Tzafrir Cohen (tzafrir) 2007-01-20 07:51:30.000-0600

A small technical comments:
The first two hunks of your patch seem to be purely "whitespace damages": only changes to white spaces and not actual code changes.

I haven't tried to apply your patch yet, so I'm only reading it. one of the commens is: "If argv[3] is a number, assume it's a trunkgroup, otherwise assume it's the requested context". Why a trunk group, and not a span?

Is a span implicitly a trunk group?

Can you have a context whose name is a number?

By: Dwayne Hubbard (dhubbard) 2007-03-27 19:16:23

Did not use supplied patch, but implemented the requested functionality as optional arguments to 'zap show channels'.  Can filter on trunkgroup, group, and context.