| Summary: | ASTERISK-06340: [patch] extra ';' in AST_LIST_HEAD_STATIC and AST_LIST_HEAD_NOLOCK_STATIC | ||
| Reporter: | Luigi Rizzo (rizzo) | Labels: | |
| Date Opened: | 2006-02-16 13:58:07.000-0600 | Date Closed: | 2006-02-16 15:54:07.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | these two macros definitions, in linkedlists.h have a trailing ';' that should be removed. Otherwise, the recommended use AST_LIST_HEAD_STATIC(...); in the middle of a list of variable declarations (e.g. app_voicemail.c) puts an empty statement between the declarations thus causing the variable declarations to appear in the middle of a block (and break compilation on older compilers for no useful reason). The trivial fix is remove the ';' from the definition. (variable declarations from the middle of the block have been reported on mantis and removed multiple times in the past so i assume there is agreement on this issue). | ||
| Comments: | By: Tilghman Lesher (tilghman) 2006-02-16 15:54:07.000-0600 Committed to trunk | ||