Summary:	ASTERISK-06337: [branch][post 1.4] Initial ast_vm_message abstraction
Reporter:	Andrew Moise (chops)	Labels:
Date Opened:	2006-02-16 11:44:50.000-0600	Date Closed:	2011-06-07 14:10:01
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 2006-02-16-vm-message-leave-voicemail.patch ( 1) 2006-02-18-vm-message-leave-voicemail-wip.patch
Description:	This is a first step at abstracting voicemail messages into an opaque handle with a set of accessor functions.  This patch creates a struct ast_vm_message and an incomplete handful of accessor functions, and converts leave_voicemail to use the message handles instead of direct access to the voicemail files and such. This patch also happens to fix a bug wherein leaving messages for multiple people (e.g. Voicemail(u1234&1235)) wouldn't work if the second person had never received voicemail.  The call to create_dirpath happened near the top of leave_voicemail(), but it didn't happen again for the secondary recipients.  Since create_dirpath is now abstracted into the message-handling layer, it does happen. This patch applies on top of SVN 10255 with both of my previous patches (http://bugs.digium.com/view.php?id=6503 and http://bugs.digium.com/view.php?id=6504) applied.  This is part of my app_voicemail.c refactoring, as discussed in http://www.voip-info.org/wiki-Asterisk+Voicemail+Redesign .  As before, I'm expecting more to generate discussion with this patch than see it applied, though I'd be very happy to see it applied.
Comments:	By: Serge Vecher (serge-v) 2006-02-16 12:09:39.000-0600 chops: nice patch. Could you please clarify the disclaimer status? Two of your other bugs have disclaimer set to "yes", this one is "no". By: Andrew Moise (chops) 2006-02-16 12:14:26.000-0600 Whoops; sorry about that.  Yes, I have signed a disclaimer; I sent it in yesterday (2006-02-15). By: Andrew Moise (chops) 2006-02-18 13:24:11.000-0600 One of my previous patches has been applied in a modified form, so I've upload a new patch.  You should check out SVN (I used rev 10353), apply my patch at http://bugs.digium.com/file_download.php?file_id=9363&type=bug , and then you can apply the 2006-02-18 patch attached to this bug. By: Olle Johansson (oej) 2006-03-10 02:14:46.000-0600 I've committed your patches to a branch named http://svn.digium.com/svn/asterisk/team/oej/voicemail-ng This will be automatically kept in synch with svn trunk. This does not mean I endorse this patch or have tested it, I just want to help you with your work since you seem to have a lot of good ideas. Voicemail really needs a lot of attention. Future patches would have to be against this branch. I will commit then to the branch for you. Also, please look at the new functions for creating dynamic menus that we now have in Asterisk. They should be a good platform for creating more configurable menus in voicemail. Now, mail to the mailing lists, ask people to test this, to give you feedback and create some attention for your work. Almost everyone uses voicemail and loves to hate it, so you should be able to get a lot of feedback. By: jmls (jmls) 2006-10-31 11:01:52.000-0600 /housekeeping: where are we with this ? By: jmls (jmls) 2006-12-05 04:41:12.000-0600 ping. housekeeping By: Serge Vecher (serge-v) 2006-12-05 08:46:59.000-0600 I think this falls into the same "gray" category as 6504. Given qwell's thoughts on that issue, I would leave the determination on what to do with this and 6504 up to one of the developers involved in the astse effort. By: Jason Parker (jparker) 2006-12-05 11:15:26.000-0600 I agree with serge.  Let's go ahead and leave this be until we have some time to figure out how this (and the other) might fit in with the ast_storage stuff. By: Leif Madsen (lmadsen) 2007-10-31 10:50:29 /housekeeping Since 6504 is now closed, what are we to do with this patch? By: Leif Madsen (lmadsen) 2007-10-31 10:51:17 I've assigned this to Qwell since he commented on it :) Feel free to re-assign, but this was set to 'assigned' with no assignee. By: Jason Parker (jparker) 2007-10-31 13:34:29 Let's go ahead and close for now.  This is going to need to be basically rewritten when everything else goes in. By: Digium Subversion (svnbot) 2008-01-15 17:21:57.000-0600 Repository: asterisk Revision: 12490 U   team/oej/voicemail-ng/apps/app_voicemail.c ------------------------------------------------------------------------ r12490 | oej | 2008-01-15 17:21:57 -0600 (Tue, 15 Jan 2008) | 2 lines Issue ASTERISK-6337 - ast_vm_message abstraction ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=12490