| Summary: | ASTERISK-06328: [patch] Clarify 'mailbox' terminology | ||
| Reporter: | Andrew Moise (chops) | Labels: | |
| Date Opened: | 2006-02-15 18:54:50.000-0600 | Date Closed: | 2006-02-16 16:14:46.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_voicemail |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 2006-02-15-terminology-cleanup-2.patch | |
| Description: | app_voicemail.c uses the word 'mailbox' for two different concepts: the extension with which the voicemail is associated (e.g. 1234), and the subfolder (e.g. INBOX, Old, etc.) where the voicemail resides. This is confusing and leads to bizarre comments like "if the mailbox has 100+ messages in the mailbox" (with a different meaning for each mention of the word). This patch partially clarifies the situation by changing most uses of the word 'mailbox' to either 'ext' (for extension) or 'folder' (for folder). All the external interfaces like database tables and command-line help texts are left alone. I sent a disclaimer in just tonight. | ||
| Comments: | By: Andrew Moise (chops) 2006-02-16 11:51:04.000-0600 This is part of my app_voicemail.c refactoring patches, discussed more at http://www.voip-info.org/wiki/view/Asterisk+Voicemail+Redesign . By: Tilghman Lesher (tilghman) 2006-02-16 16:14:46.000-0600 Committed only the rename to the folder terms. The mailbox term stayed the same. It still clears up the confusion, with a lot less lines changed. | ||