[Home]

Summary:ASTERISK-06192: [patch] make possible to define prefix for automon saved files
Reporter:Ivan F. Martinez (ivanfm)Labels:
Date Opened:2006-01-25 11:54:05.000-0600Date Closed:2007-10-15 14:47:25
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 6353-touch_monitor_prefix.diff
( 1) asterisk_automon_v4.patch
Description:make possible to specify a different prefix for automon saved files.

Actualy is possible to change sufix by using TOUCH_MONITOR variable, but using it we lost the caller id information.

this new variable change the prefix from "auto" to the value of TOUCH_MONITOR_PREF

sample usage at sip.conf:

[clientname]
...parameters...
setvar=TOUCH_MONITOR_PREF=boss_automon_call



****** ADDITIONAL INFORMATION ******

the patch does not change any behaviour of asterisk, only who define the new variable will see the changes.
Comments:By: Matt Riddell (zx81) 2006-01-25 19:26:25.000-0600

Would it not make more sense to find the problem with CDR being lost?

What exactly happens?  Do you end up with no CDR/wrong CDR?
By: Ivan F. Martinez (ivanfm) 2006-01-26 03:54:15.000-0600

there are 2 formats for automon file names :
auto-TIME-CALLER-CALLED.${TOUCH_MONITOR_FORMAT}
auto-TIME-${TOUCH_MONITOR}.${TOUCH_MONITOR_FORMAT}

as it already has 2 formats I don't wanted to change they and just make
the prefix "auto" configurable.

But if you think that we can change the actual format of file name, maybe the best will be change the second format to :
${TOUCH_MONITOR}-TIME-CALLER-CALLED.${TOUCH_MONITOR_FORMAT}


If you agree I can change the patch.
By: Matt Riddell (zx81) 2006-01-26 07:14:48.000-0600

Why don't you just set touch_monitor to yourval.timerecvd or whatever?
By: Ivan F. Martinez (ivanfm) 2006-01-26 13:40:04.000-0600

*1 is controled directly by asterisk res_features, in this case I don't know how to change a variable. How can I do this ?

If we set the variable at dialplan, the value will be the value at start of call not the time when user press *1.

I just want to make the filename easy to understand, each administrator can set at channel a variable to change the values.

Maybe a better thing will be to use a configurable expression ant this will make easier to anyone use a customized filename.

I will think about this and create a new patch, using other asterisk routines.
By: Ivan F. Martinez (ivanfm) 2006-01-26 17:37:15.000-0600

this new version make filename fully configurable using pbx_substitute_variables_helper.

Also make possible to user known when monitoring weas started and stopped.

Using different courtesy sound files make easier to user know when monitoring was started and stopped.
By: Serge Vecher (serge-v) 2006-05-04 09:30:36

ivanfm: can you please update the patch here? Thanks!!!
By: Serge Vecher (serge-v) 2006-05-22 15:51:58

also, since this is a new feature, the patch should be against latest trunk.
By: Serge Vecher (serge-v) 2006-06-07 15:57:55

ivanfm, please update this one also. Obrigado.
By: Ivan F. Martinez (ivanfm) 2006-06-07 19:30:40

updated to trunk
By: jmls (jmls) 2006-10-31 11:48:43.000-0600

ivanfm, would you be so kind as to update this for trunk ? Thanks.
By: jmls (jmls) 2007-01-01 12:49:25.000-0600

ping - is there an update available ?
By: Ivan F. Martinez (ivanfm) 2007-01-01 15:47:38.000-0600

updated to current trunk
By: jmls (jmls) 2007-01-02 02:45:20.000-0600

Thanks for the quick response. Devs - can we get someone to look at this now ? Thanks.
By: jmls (jmls) 2007-09-12 16:29:07

this was updated to trunk a while ago. Is it worth asking the author to update it again so it can be looked at, or shall we close ?
By: Jason Parker (jparker) 2007-09-13 11:48:34

I don't understand why this is including changes for automon_courtesy_start and automon_courtesy_stop and such.

It seems to me that it should be as easy as the patch I'm going to upload in a moment here.
By: dimitripietro (dimitripietro) 2007-09-13 20:49:36

Using Asterisk SVN-trunk-r82359, Asterisk Crash when using the automon feature with your patch or without it.

With Asterisk 1.4.11, your patch apply with problem but is not working.
By: Clod Patry (junky) 2007-10-07 22:58:43

Why not having just one chanvar: TOUCH_MONITOR that could set everything ?
Cause these patches set the time when the monitor has started, what about if we dont want it?
What I propose is just having the variable TOUCH_MONITOR to control the EXACT filename, no need of 2 chanvar for just 1 filename, no?

If TOUCH_MONITOR isn't set, that could be set to the default settting.
By: Digium Subversion (svnbot) 2007-10-15 14:47:23

Repository: asterisk
Revision: 85682

U   trunk/CHANGES
U   trunk/res/res_features.c

------------------------------------------------------------------------
r85682 | russell | 2007-10-15 14:47:22 -0500 (Mon, 15 Oct 2007) | 10 lines

Added support for reading the TOUCH_MONITOR_PREFIX channel variable.
It allows you to configure a prefix for auto-monitor recordings.

(closes issue ASTERISK-6192)
Reported by: ivanfm
Patches:
     asterisk_automon_v4.patch uploaded by ivanfm (original patch)
  - updated patch:
        6353-touch_monitor_prefix.diff uploaded by qwell (license 4)

------------------------------------------------------------------------