Summary:	ASTERISK-06163: build for func_odbc broken on FreeBSD
Reporter:	quiescent (quiescent)	Labels:
Date Opened:	2006-01-22 13:33:02.000-0600	Date Closed:	2008-01-15 16:29:55.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	gcc cannot find -lodbc when building func_odbc on FreeBSD.  funcs/Makefile needs to add -L/usr/local flag for func_odbc.o target when compiling under FreeBSD.
Comments:	By: Russell Bryant (russell) 2006-01-22 13:41:42.000-0600 I thought this would be taken care of by the following statement in the main Makefile: ifeq ($(findstring BSD,$(OSARCH)),BSD)  PROC=$(shell uname -m)  ASTCFLAGS+=-I$(CROSS_COMPILE_TARGET)/usr/local/include -L$(CROSS_COMPILE_TARGET)/usr/local/lib endif By: quiescent (quiescent) 2006-01-22 16:49:18.000-0600 Hm.  I didn't see that that there.  Anyway, ASTCFLAGS isn't used for the func_odbc.o target in funcs/Makefile. By: Olle Johansson (oej) 2006-01-24 06:54:07.000-0600 Fixed in svn trunk, rev 8539. Already fixed in 1.2 it seems. By: Olle Johansson (oej) 2006-01-24 06:54:24.000-0600 Thank you for reporting this! By: Russell Bryant (russell) 2006-01-24 09:46:57.000-0600 The lines that you added to the Makefile were actually removed in the previous revision, as discussed in ASTERISK-6092.  The reason that you saw them in 1.2 is because they were never removed there. I don't feel that this should have been added back into the Makefile.  The ASTCFLAGS should carry over into all of the sub-Makefiles.  Instead, we need to figure out why it is not working in this case.  Perhaps it is a version issue with gnu make. By: Russell Bryant (russell) 2006-01-24 09:52:50.000-0600 Also note that CFLAGS is set to what we have built in ASTCFLAGS in the main Makefile. By: Luigi Rizzo (rizzo) 2006-01-24 10:34:20.000-0600 the real problem is that ASTCFLAGS contains both compiler (-I...) and linker (-L...) flags, whereas in some of the subdirectories the linker flags are in the SOLINK variable. However SOLINK is not used everywhere, see the grep result at the end. so 1) a temporary workaround is to put, in the main Makefile, the -L/usr/local/lib e.g. as below near line 230 ifeq ($(findstring BSD,$(OSARCH)),BSD)   PROC=$(shell uname -m)   ASTCFLAGS+=-I$(CROSS_COMPILE_TARGET)/usr/local/include -L ....   +  SOLINK+=-L$(CROSS_COMPILE_TARGET)/usr/local/lib endif and in the long term to rework the sudir makefiles to be more consistent in the use of CFLAGS and SOLINK. Linux also would have the same problem, but probably there /usr/local/lib is one of the default places where to look. > grep -l SOLINK */Makefile apps/Makefile cdr/Makefile channels/Makefile codecs/Makefile formats/Makefile funcs/Makefile pbx/Makefile res/Makefile > grep -l CFLAGS */Makefile agi/Makefile apps/Makefile cdr/Makefile channels/Makefile codecs/Makefile db1-ast/Makefile editline/Makefile formats/Makefile funcs/Makefile pbx/Makefile res/Makefile stdtime/Makefile utils/Makefile By: Olle Johansson (oej) 2006-01-24 10:48:46.000-0600 ...sorry. I just copied from res/Makefile that still used the old method. I removed my change from trunk while waiting for a proper fix. By: Russell Bryant (russell) 2006-01-26 22:34:24.000-0600 I have added /usr/local/lib to SOLINK in the main Makefile.  This change was made in the trunk in revisoin 8778. By: Digium Subversion (svnbot) 2008-01-15 16:23:05.000-0600 Repository: asterisk Revision: 8539 U   trunk/funcs/Makefile ------------------------------------------------------------------------ r8539 | oej | 2008-01-15 16:23:04 -0600 (Tue, 15 Jan 2008) | 2 lines Issue ASTERISK-6163, FreeBSD compatibility with compilation of func_odbc.c (reported by nulbyte) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8539 By: Digium Subversion (svnbot) 2008-01-15 16:25:13.000-0600 Repository: asterisk Revision: 8679 _U  team/oej/astum/ D   team/oej/astum/ChangeLog U   team/oej/astum/apps/app_dial.c U   team/oej/astum/asterisk.c U   team/oej/astum/cdr/cdr_pgsql.c U   team/oej/astum/channel.c U   team/oej/astum/channels/chan_agent.c U   team/oej/astum/channels/chan_features.c U   team/oej/astum/channels/chan_iax2.c U   team/oej/astum/channels/chan_sip.c U   team/oej/astum/configs/sip.conf.sample U   team/oej/astum/contrib/scripts/safe_asterisk U   team/oej/astum/include/asterisk/channel.h U   team/oej/astum/rtp.c U   team/oej/astum/utils/astman.c ------------------------------------------------------------------------ r8679 | oej | 2008-01-15 16:25:13 -0600 (Tue, 15 Jan 2008) | 230 lines Merged revisions 8517,8523-8524,8531,8538-8539,8548,8554,8560-8561,8563,8571-8572,8574,8582,8587,8589-8597,8599,8609-8610,8618,8620,8633,8642-8643,8654,8664-8665,8667,8676,8678 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8517 | oej | 2006-01-24 11:36:45 +0100 (Tue, 24 Jan 2006) | 2 lines Whitespace change, extra <tab> added from my tab storage. ................ r8523 | oej | 2006-01-24 12:42:09 +0100 (Tue, 24 Jan 2006) | 2 lines Declaring conn and result static to avoid collission with realtime driver (issue 6336, pressureman) ................ r8524 | oej | 2006-01-24 12:46:29 +0100 (Tue, 24 Jan 2006) | 3 lines - Adding whitespace that I found unused outside - Adding "if (option_debug)" before outputting to DEBUG channel ................ r8531 | oej | 2006-01-24 13:48:44 +0100 (Tue, 24 Jan 2006) | 2 lines - Report SIP reload in manager (issue 5742 with small changes) ................ r8538 | oej | 2006-01-24 14:21:13 +0100 (Tue, 24 Jan 2006) | 2 lines Importing rev ASTERISK-8302 from 1.2, never send response to ACK (issue ASTERISK-6148) ................ r8539 | oej | 2006-01-24 14:53:45 +0100 (Tue, 24 Jan 2006) | 2 lines Issue ASTERISK-6163, FreeBSD compatibility with compilation of func_odbc.c (reported by nulbyte) ................ r8548 | oej | 2006-01-24 18:47:41 +0100 (Tue, 24 Jan 2006) | 2 lines Reverting change in revision 8539 - fixed wrong problem. Sorry. ................ r8554 | oej | 2006-01-24 19:15:20 +0100 (Tue, 24 Jan 2006) | 2 lines Make it clear that caller ID in sip.conf is used only on incoming calls (inspired by bug ASTERISK-6026) ................ r8560 | oej | 2006-01-24 20:08:44 +0100 (Tue, 24 Jan 2006) | 2 lines Issue ASTERISK-5935: Match realtime non-dynamic peers by IP. (siacali). ................ r8561 | oej | 2006-01-24 20:19:20 +0100 (Tue, 24 Jan 2006) | 2 lines Issue 6114: Don't hangup on bye/also if there's no channel. (gst) ................ r8563 | oej | 2006-01-24 20:29:32 +0100 (Tue, 24 Jan 2006) | 2 lines Blocking fix from 1.2 from being applied again. ................ r8571 | russell | 2006-01-24 21:20:05 +0100 (Tue, 24 Jan 2006) | 2 lines convert ast_channel list to use linked list macros (issue ASTERISK-6178) ................ r8572 | russell | 2006-01-24 21:27:09 +0100 (Tue, 24 Jan 2006) | 2 lines store the list of 'atexit' functions using linked list macros (issue ASTERISK-6169) ................ r8574 | oej | 2006-01-24 21:41:08 +0100 (Tue, 24 Jan 2006) | 2 lines Don't reset scheduled ID until we actually end the scheduled event. ................ r8582 | mattf | 2006-01-24 22:45:42 +0100 (Tue, 24 Jan 2006) | 2 lines Updates from royk to safe_asterisk (ASTERISK-5069) Thanks! ................ r8587 | mattf | 2006-01-24 23:06:37 +0100 (Tue, 24 Jan 2006) | 2 lines Make sure safe_asterisk retains previous script defaults ................ r8589 | kpfleming | 2006-01-24 23:33:58 +0100 (Tue, 24 Jan 2006) | 1 line ................ r8590 | kpfleming | 2006-01-24 23:34:06 +0100 (Tue, 24 Jan 2006) | 1 line ................ r8591 | kpfleming | 2006-01-24 23:38:17 +0100 (Tue, 24 Jan 2006) | 10 lines Merged revisions 8588 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8588 | kpfleming | 2006-01-24 16:32:09 -0600 (Tue, 24 Jan 2006) | 2 lines ensure that channel cannot become zombie after we check but before we try to start indications ........ ................ r8592 | kpfleming | 2006-01-24 23:40:20 +0100 (Tue, 24 Jan 2006) | 1 line ................ r8593 | kpfleming | 2006-01-24 23:40:57 +0100 (Tue, 24 Jan 2006) | 1 line ................ r8594 | kpfleming | 2006-01-24 23:41:45 +0100 (Tue, 24 Jan 2006) | 1 line ................ r8595 | kpfleming | 2006-01-24 23:42:43 +0100 (Tue, 24 Jan 2006) | 10 lines Merged revisions 8173 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8173 | russell | 2006-01-17 20:49:21 -0600 (Tue, 17 Jan 2006) | 2 lines remove ChangeLog from the 1.2 branch.  It will only be present in the tags. ........ ................ r8596 | kpfleming | 2006-01-24 23:43:30 +0100 (Tue, 24 Jan 2006) | 1 line ................ r8597 | kpfleming | 2006-01-24 23:43:57 +0100 (Tue, 24 Jan 2006) | 2 lines clean up remaining already-merged revisions ................ r8599 | kpfleming | 2006-01-24 23:45:41 +0100 (Tue, 24 Jan 2006) | 2 lines remove extraneous characters from property ................ r8609 | kpfleming | 2006-01-25 02:52:58 +0100 (Wed, 25 Jan 2006) | 10 lines Merged revisions 8608 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8608 | kpfleming | 2006-01-24 19:50:52 -0600 (Tue, 24 Jan 2006) | 2 lines ensure hangup cause code is handled properly when channel does not return a frame (issue ASTERISK-6186) ........ ................ r8610 | kpfleming | 2006-01-25 02:53:15 +0100 (Wed, 25 Jan 2006) | 1 line ................ r8618 | russell | 2006-01-25 06:37:29 +0100 (Wed, 25 Jan 2006) | 3 lines don't leak almost 200 bytes for each new channel and store the active channel list using the linked list macros (issue ASTERISK-6170) ................ r8620 | russell | 2006-01-25 06:39:25 +0100 (Wed, 25 Jan 2006) | 1 line ................ r8633 | oej | 2006-01-25 10:50:28 +0100 (Wed, 25 Jan 2006) | 2 lines Issue ASTERISK-6189 - patch by markster, imported from 1.2 ................ r8642 | oej | 2006-01-25 13:01:07 +0100 (Wed, 25 Jan 2006) | 3 lines From now on, apply maxexpiry and minexpiry to all subscriptions. Thanks to fourcheeze in the IRC channel for pointing this out. ................ r8643 | oej | 2006-01-25 13:11:30 +0100 (Wed, 25 Jan 2006) | 3 lines - Remove unused option to transmit_state_notify - Allow for expiry=0 in subscription requests that only wants *one* update and that's it. ................ r8654 | kpfleming | 2006-01-25 15:52:43 +0100 (Wed, 25 Jan 2006) | 3 lines don't queue a congestion frame on a channel that will be immediately hung up anyway clean up/organize code block ................ r8664 | russell | 2006-01-25 19:12:55 +0100 (Wed, 25 Jan 2006) | 2 lines store agent_pvt list using linked list macros (issue ASTERISK-6182) ................ r8665 | russell | 2006-01-25 19:24:32 +0100 (Wed, 25 Jan 2006) | 3 lines store feature_pvt list using linked list macros (issue ASTERISK-6190, with additional changes to prevent a memory leak in unload_module) ................ r8667 | russell | 2006-01-25 19:41:12 +0100 (Wed, 25 Jan 2006) | 1 line ................ r8676 | russell | 2006-01-25 20:06:37 +0100 (Wed, 25 Jan 2006) | 2 lines use arg parsing macros in the AGENT dialplan function (issue ASTERISK-6078, with small mods) ................ r8678 | russell | 2006-01-25 20:16:14 +0100 (Wed, 25 Jan 2006) | 11 lines Merged revisions 8677 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8677 | russell | 2006-01-25 14:14:43 -0500 (Wed, 25 Jan 2006) | 3 lines don't call ast_update_realtime with uninitialized variables if we get a registration with an expirey of 0 seconds (issue ASTERISK-6016) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8679 By: Digium Subversion (svnbot) 2008-01-15 16:26:43.000-0600 Repository: asterisk Revision: 8778 U   trunk/Makefile ------------------------------------------------------------------------ r8778 | russell | 2008-01-15 16:26:43 -0600 (Tue, 15 Jan 2008) | 2 lines add /usr/local/lib to SOLINK (issue ASTERISK-6163) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8778 By: Digium Subversion (svnbot) 2008-01-15 16:28:22.000-0600 Repository: asterisk Revision: 8890 _U  team/oej/jitterbuffer/ U   team/oej/jitterbuffer/Makefile U   team/oej/jitterbuffer/UPGRADE.txt U   team/oej/jitterbuffer/apps/app_dial.c U   team/oej/jitterbuffer/apps/app_externalivr.c U   team/oej/jitterbuffer/apps/app_meetme.c U   team/oej/jitterbuffer/ast_expr2.c U   team/oej/jitterbuffer/ast_expr2.h U   team/oej/jitterbuffer/ast_expr2f.c U   team/oej/jitterbuffer/channel.c U   team/oej/jitterbuffer/channels/chan_agent.c U   team/oej/jitterbuffer/channels/chan_features.c U   team/oej/jitterbuffer/channels/chan_iax2.c U   team/oej/jitterbuffer/channels/chan_sip.c U   team/oej/jitterbuffer/channels/chan_zap.c U   team/oej/jitterbuffer/funcs/func_md5.c U   team/oej/jitterbuffer/include/asterisk/channel.h U   team/oej/jitterbuffer/include/asterisk/frame.h U   team/oej/jitterbuffer/res/Makefile ------------------------------------------------------------------------ r8890 | oej | 2008-01-15 16:28:22 -0600 (Tue, 15 Jan 2008) | 188 lines Merged revisions 8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines Merged revisions 8710 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines Issue 5898: Registrations does not get deleted if there's an active SIP dialog ........ ................ r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines Add some debugging output when reloading, to be able to follow progress at high debug levels ................ r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines store conference list using linked list macros (issue ASTERISK-6167) ................ r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines Code clean up, inspired by rizzo's comments in issue 5978. - Don't check for ignore if ignore is always negative - Add comments to explain what's going on ................ r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines Merged revisions 8729 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines fix problem with dtmf on e&m (issue ASTERISK-6203) ........ ................ r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines Issue ASTERISK-5799 revisited. Thanks rizzo. ................ r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines Formatting fixes, speling eror fiksd ;-) ................ r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059) ................ r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines - Move two functions to static that wasn't for some reason - Add doxygen comments - Remove un-needed assignment at declaration of variable - Formatting fixes (whitespace) - Add optin_debug in front of complex debugging output - Move forward declarations of functions to top of file - Fix error message for bad allocation in sip registry (Note: Review to line 6050 in this too large file) ................ r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059) ................ r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines Merged revisions 8758 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files ........ ................ r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines add /usr/local/lib to SOLINK (issue ASTERISK-6163) ................ r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines remove some more redundant flags ................ r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines Merged revisions 8785 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines Issue 6362 - Register without Contact: and Expires: fails (reporter: op) ........ ................ r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188) ................ r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines Blocking revision 8808 from trunk. It's already fixed in trunk. ................ r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines Simplify code for building Call ID's, create generic random string function ................ r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines - Moving forward declarations to one block - Moving global variables to one block - Moving global networking variables to one block - Small whitespace changes - Renaming a few more global channel settings to global_ for clarity (No functional changes) ................ r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines Doxygen updates ................ r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines Change booleans to TRUE/FALSE. (At some point we should implement these as enums to simplify debugging) ................ r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines - Remove unused "resetinvite" variable - Use TRUE/FALSE for fastrestart ................ r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines make ast_read() able to handle channel read()/exception() methods that return a chain of frames cleanup code in ast_read() add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate ................ r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines add channel-driver callbacks for variable length DTMF teach ast_write() to call those new callbacks ................ r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events) ................ r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines Merge Rizzo's waitfor update (bug ASTERISK-4468) ................ r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines Bug 6378 - deprecate CHECK_MD5 function ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8890 By: Digium Subversion (svnbot) 2008-01-15 16:28:29.000-0600 Repository: asterisk Revision: 8893 _U  team/oej/multiparking/ U   team/oej/multiparking/Makefile U   team/oej/multiparking/UPGRADE.txt U   team/oej/multiparking/apps/app_dial.c U   team/oej/multiparking/apps/app_externalivr.c U   team/oej/multiparking/apps/app_meetme.c U   team/oej/multiparking/ast_expr2.c U   team/oej/multiparking/ast_expr2.h U   team/oej/multiparking/ast_expr2f.c U   team/oej/multiparking/channel.c U   team/oej/multiparking/channels/chan_agent.c U   team/oej/multiparking/channels/chan_features.c U   team/oej/multiparking/channels/chan_iax2.c U   team/oej/multiparking/channels/chan_sip.c U   team/oej/multiparking/channels/chan_zap.c U   team/oej/multiparking/funcs/func_md5.c U   team/oej/multiparking/include/asterisk/channel.h U   team/oej/multiparking/include/asterisk/frame.h U   team/oej/multiparking/res/Makefile ------------------------------------------------------------------------ r8893 | oej | 2008-01-15 16:28:28 -0600 (Tue, 15 Jan 2008) | 188 lines Merged revisions 8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines Merged revisions 8710 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines Issue 5898: Registrations does not get deleted if there's an active SIP dialog ........ ................ r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines Add some debugging output when reloading, to be able to follow progress at high debug levels ................ r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines store conference list using linked list macros (issue ASTERISK-6167) ................ r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines Code clean up, inspired by rizzo's comments in issue 5978. - Don't check for ignore if ignore is always negative - Add comments to explain what's going on ................ r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines Merged revisions 8729 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines fix problem with dtmf on e&m (issue ASTERISK-6203) ........ ................ r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines Issue ASTERISK-5799 revisited. Thanks rizzo. ................ r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines Formatting fixes, speling eror fiksd ;-) ................ r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059) ................ r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines - Move two functions to static that wasn't for some reason - Add doxygen comments - Remove un-needed assignment at declaration of variable - Formatting fixes (whitespace) - Add optin_debug in front of complex debugging output - Move forward declarations of functions to top of file - Fix error message for bad allocation in sip registry (Note: Review to line 6050 in this too large file) ................ r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059) ................ r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines Merged revisions 8758 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files ........ ................ r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines add /usr/local/lib to SOLINK (issue ASTERISK-6163) ................ r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines remove some more redundant flags ................ r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines Merged revisions 8785 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines Issue 6362 - Register without Contact: and Expires: fails (reporter: op) ........ ................ r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188) ................ r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines Blocking revision 8808 from trunk. It's already fixed in trunk. ................ r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines Simplify code for building Call ID's, create generic random string function ................ r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines - Moving forward declarations to one block - Moving global variables to one block - Moving global networking variables to one block - Small whitespace changes - Renaming a few more global channel settings to global_ for clarity (No functional changes) ................ r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines Doxygen updates ................ r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines Change booleans to TRUE/FALSE. (At some point we should implement these as enums to simplify debugging) ................ r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines - Remove unused "resetinvite" variable - Use TRUE/FALSE for fastrestart ................ r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines make ast_read() able to handle channel read()/exception() methods that return a chain of frames cleanup code in ast_read() add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate ................ r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines add channel-driver callbacks for variable length DTMF teach ast_write() to call those new callbacks ................ r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events) ................ r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines Merge Rizzo's waitfor update (bug ASTERISK-4468) ................ r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines Bug 6378 - deprecate CHECK_MD5 function ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8893 By: Digium Subversion (svnbot) 2008-01-15 16:29:55.000-0600 Repository: asterisk Revision: 8981 _U  team/oej/astum/ U   team/oej/astum/.cleancount U   team/oej/astum/Makefile U   team/oej/astum/UPGRADE.txt U   team/oej/astum/apps/app_dial.c U   team/oej/astum/apps/app_externalivr.c U   team/oej/astum/apps/app_meetme.c U   team/oej/astum/ast_expr2.c U   team/oej/astum/ast_expr2.h U   team/oej/astum/ast_expr2f.c U   team/oej/astum/channel.c U   team/oej/astum/channels/chan_agent.c U   team/oej/astum/channels/chan_features.c U   team/oej/astum/channels/chan_iax2.c U   team/oej/astum/channels/chan_sip.c U   team/oej/astum/channels/chan_zap.c U   team/oej/astum/configs/sip.conf.sample U   team/oej/astum/funcs/func_md5.c U   team/oej/astum/include/asterisk/channel.h U   team/oej/astum/include/asterisk/frame.h U   team/oej/astum/include/asterisk/stringfields.h U   team/oej/astum/pbx.c U   team/oej/astum/res/Makefile U   team/oej/astum/utils.c ------------------------------------------------------------------------ r8981 | oej | 2008-01-15 16:29:55 -0600 (Tue, 15 Jan 2008) | 277 lines Merged revisions 8687,8697,8711-8712,8727-8728,8730-8731,8741-8742,8750,8757,8768,8778-8779,8786,8799,8809,8823,8825-8826,8834-8835,8850-8852,8877,8883,8896,8906,8919,8925-8926,8932,8938,8948-8949,8961,8976 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r8687 | russell | 2006-01-25 21:02:12 +0100 (Wed, 25 Jan 2006) | 2 lines use arg parsing macros for WaitExten and Background (issue ASTERISK-6028) ................ r8697 | kpfleming | 2006-01-26 05:00:05 +0100 (Thu, 26 Jan 2006) | 4 lines string field manager improvements: use multiple memory blocks, instead of realloc(), ensuring that field pointers will never become invalid or change don't run vs(n)printf twice when doing a field build unless required ................ r8711 | oej | 2006-01-26 15:44:23 +0100 (Thu, 26 Jan 2006) | 10 lines Merged revisions 8710 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8710 | oej | 2006-01-26 15:39:36 +0100 (Thu, 26 Jan 2006) | 2 lines Issue 5898: Registrations does not get deleted if there's an active SIP dialog ........ ................ r8712 | oej | 2006-01-26 15:59:33 +0100 (Thu, 26 Jan 2006) | 2 lines Add some debugging output when reloading, to be able to follow progress at high debug levels ................ r8727 | russell | 2006-01-26 20:33:27 +0100 (Thu, 26 Jan 2006) | 2 lines store conference list using linked list macros (issue ASTERISK-6167) ................ r8728 | oej | 2006-01-26 20:38:11 +0100 (Thu, 26 Jan 2006) | 4 lines Code clean up, inspired by rizzo's comments in issue 5978. - Don't check for ignore if ignore is always negative - Add comments to explain what's going on ................ r8730 | russell | 2006-01-26 20:44:16 +0100 (Thu, 26 Jan 2006) | 10 lines Merged revisions 8729 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8729 | russell | 2006-01-26 14:42:35 -0500 (Thu, 26 Jan 2006) | 2 lines fix problem with dtmf on e&m (issue ASTERISK-6203) ........ ................ r8731 | oej | 2006-01-26 20:47:40 +0100 (Thu, 26 Jan 2006) | 2 lines Issue ASTERISK-5799 revisited. Thanks rizzo. ................ r8741 | oej | 2006-01-26 21:08:53 +0100 (Thu, 26 Jan 2006) | 2 lines Formatting fixes, speling eror fiksd ;-) ................ r8742 | russell | 2006-01-26 21:28:52 +0100 (Thu, 26 Jan 2006) | 2 lines don't redefine the localuser struct for additional use specific to the module (issue ASTERISK-6059) ................ r8750 | oej | 2006-01-26 22:36:41 +0100 (Thu, 26 Jan 2006) | 9 lines - Move two functions to static that wasn't for some reason - Add doxygen comments - Remove un-needed assignment at declaration of variable - Formatting fixes (whitespace) - Add optin_debug in front of complex debugging output - Move forward declarations of functions to top of file - Fix error message for bad allocation in sip registry (Note: Review to line 6050 in this too large file) ................ r8757 | russell | 2006-01-27 01:31:05 +0100 (Fri, 27 Jan 2006) | 2 lines don't re-define the localuser struct for custom use inside the module (issue ASTERISK-6059) ................ r8768 | tilghman | 2006-01-27 02:04:03 +0100 (Fri, 27 Jan 2006) | 11 lines Merged revisions 8758 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8758 | tilghman | 2006-01-26 18:52:12 -0600 (Thu, 26 Jan 2006) | 2 lines Bug 6072 - Revisions to the source bison and flex files don't auto-regenerate these files ........ ................ r8778 | russell | 2006-01-27 06:33:20 +0100 (Fri, 27 Jan 2006) | 2 lines add /usr/local/lib to SOLINK (issue ASTERISK-6163) ................ r8779 | russell | 2006-01-27 06:39:20 +0100 (Fri, 27 Jan 2006) | 2 lines remove some more redundant flags ................ r8786 | oej | 2006-01-27 09:07:43 +0100 (Fri, 27 Jan 2006) | 10 lines Merged revisions 8785 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8785 | oej | 2006-01-27 09:02:16 +0100 (Fri, 27 Jan 2006) | 2 lines Issue 6362 - Register without Contact: and Expires: fails (reporter: op) ........ ................ r8799 | mattf | 2006-01-28 00:55:37 +0100 (Sat, 28 Jan 2006) | 2 lines Add rdnis rx/tx support to chan_iax2 (ASTERISK-6188) ................ r8809 | oej | 2006-01-28 14:54:25 +0100 (Sat, 28 Jan 2006) | 2 lines Blocking revision 8808 from trunk. It's already fixed in trunk. ................ r8823 | oej | 2006-01-28 16:02:29 +0100 (Sat, 28 Jan 2006) | 2 lines Simplify code for building Call ID's, create generic random string function ................ r8825 | oej | 2006-01-28 16:28:58 +0100 (Sat, 28 Jan 2006) | 7 lines - Moving forward declarations to one block - Moving global variables to one block - Moving global networking variables to one block - Small whitespace changes - Renaming a few more global channel settings to global_ for clarity (No functional changes) ................ r8826 | oej | 2006-01-28 16:34:27 +0100 (Sat, 28 Jan 2006) | 2 lines Doxygen updates ................ r8834 | oej | 2006-01-28 18:00:05 +0100 (Sat, 28 Jan 2006) | 3 lines Change booleans to TRUE/FALSE. (At some point we should implement these as enums to simplify debugging) ................ r8835 | oej | 2006-01-28 18:17:37 +0100 (Sat, 28 Jan 2006) | 3 lines - Remove unused "resetinvite" variable - Use TRUE/FALSE for fastrestart ................ r8850 | kpfleming | 2006-01-29 06:07:04 +0100 (Sun, 29 Jan 2006) | 5 lines make ast_read() able to handle channel read()/exception() methods that return a chain of frames cleanup code in ast_read() add AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END so that variable-length DTMF events can be supported teach chan_zap to send DTMF_BEGIN and DTMF_END when appropriate ................ r8851 | kpfleming | 2006-01-29 06:15:24 +0100 (Sun, 29 Jan 2006) | 3 lines add channel-driver callbacks for variable length DTMF teach ast_write() to call those new callbacks ................ r8852 | kpfleming | 2006-01-29 06:29:29 +0100 (Sun, 29 Jan 2006) | 2 lines don't use tone generation for DTMF if the channel driver only supports begin/end (will need more work to translate non-variable events into begin/end events) ................ r8877 | markster | 2006-01-30 04:13:33 +0100 (Mon, 30 Jan 2006) | 2 lines Merge Rizzo's waitfor update (bug ASTERISK-4468) ................ r8883 | tilghman | 2006-01-30 07:07:05 +0100 (Mon, 30 Jan 2006) | 2 lines Bug 6378 - deprecate CHECK_MD5 function ................ r8896 | oej | 2006-01-30 15:12:39 +0100 (Mon, 30 Jan 2006) | 2 lines Document installation changes for BSD users. ................ r8906 | kpfleming | 2006-01-30 18:09:55 +0100 (Mon, 30 Jan 2006) | 10 lines Merged revisions 8905 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r8905 | kpfleming | 2006-01-30 11:08:28 -0600 (Mon, 30 Jan 2006) | 2 lines disable buggy PRI user-user code until it can be fixed ........ ................ r8919 | oej | 2006-01-30 19:51:02 +0100 (Mon, 30 Jan 2006) | 6 lines Issue ASTERISK-5643 - simplification of check_auth - constifications - whitespace changes Rizzo's patch with some changes ................ r8925 | oej | 2006-01-30 20:09:08 +0100 (Mon, 30 Jan 2006) | 3 lines Issue ASTERISK-5876 - Don't send 403 on bad auth (correcting one of my old mistakes...) Reported by maik. Patch inspired by, but not the patch in the bug tracker. ................ r8926 | oej | 2006-01-30 20:50:39 +0100 (Mon, 30 Jan 2006) | 2 lines Issue 5892: Set a minimum T1 timer for calls. Reporter: twisted ................ r8932 | oej | 2006-01-30 21:36:38 +0100 (Mon, 30 Jan 2006) | 8 lines - Doxygen and comments updates - Moving structure declarations to top of file with the rest - Adding some forward declarations for RTP interface functions (All these changes to position in file are in preparation for splitting chan_sip up into several files at some point in the future) ................ r8938 | mogorman | 2006-01-30 22:16:43 +0100 (Mon, 30 Jan 2006) | 3 lines reverting  blocks 9 and 10 from revision 7547 fixes bug 6080 ................ r8948 | kpfleming | 2006-01-31 01:17:43 +0100 (Tue, 31 Jan 2006) | 2 lines increment for recent ast_channel change ................ r8949 | russell | 2006-01-31 01:24:34 +0100 (Tue, 31 Jan 2006) | 3 lines add a note to hopefully decrease the chance that someone forgets to increment .cleancount after changing the ast_channel structure ................ r8961 | kpfleming | 2006-01-31 04:45:09 +0100 (Tue, 31 Jan 2006) | 2 lines Yes Virginia, Zaptel does support native ALAW ................ r8976 | oej | 2006-01-31 15:30:09 +0100 (Tue, 31 Jan 2006) | 3 lines - Change "prefs" to "default_prefs" and move declaration to "default" group - Add doxygen comments ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=8981