Summary:	ASTERISK-06155: [patch] disable ringing on busy members that support AST_DEVICE_INUSE
Reporter:	Boris Erdmann (be4ct)	Labels:
Date Opened:	2006-01-21 08:49:09.000-0600	Date Closed:	2008-01-15 16:48:12.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_queue
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_queue-ringinuse.patch
Description:	Disable ringing on busy members that support AST_DEVICE_INUSE Copies the behaviour of not ringing paused members in ring_entry of app_queue.c Features a switch 'ring-inuse' in queue.conf: [myqueue] ring-inuse=yes; the old behaviour (default)
Comments:	By: Boris Erdmann (be4ct) 2006-01-21 09:05:14.000-0600 Testing would be appreciated! BTW: I have only knowledge about chan_sip supporting the required AST_DEVICE_INUSE state. By: wes (whoiswes) 2006-01-21 09:39:56.000-0600 be4ct- I can confirm this patch works with 1.2.1 wonderfully!  Watching the CLI shows that app_queue is now checking the availibility of an agent before sending the call.  This, coupled with Cyrax's patch in bug 6111, finally allows our call center to have multi-line phones that do not receive multiple calls while in queue, something that has plauged us since day one with Asterisk! We are running a default 1.2.1 install except for the two patches listed above and the system finally is running exactly how I belive it should be - thanks to you both!!!!!!  Put this patch in the source! Wes By: Boris Erdmann (be4ct) 2006-01-21 10:16:08.000-0600 So i dont want to conceil what i already mailed to wes <quote> I recognised a slight disorder whith respect to the round robin strategy: after skiping a busy phone, sometimes the phone that was free next in line will be called again by app_queue. So far i don't know if that is true for paused members as well. </quote> By: Tilghman Lesher (tilghman) 2006-01-21 13:36:18.000-0600 Cannot be merged without a disclaimer on file. By: Boris Erdmann (be4ct) 2006-01-21 14:40:38.000-0600 Disclaimer ID: +49.4354.99xxxx By: Boris Erdmann (be4ct) 2006-01-22 11:23:14.000-0600 OK - just a little confused and, well, interested: I sent the 'disclaimer on file' fax. Version, SVN Branch and Summary got updated by bweschke. Still 'Disclaimer on File' set to 'No'. What does this actually mean?. Patch accepted despite the disclaimer being not accepted? Then why the latter? Or patch not accepted (dont dare to ask why since it does not comply with the guidelines, which i could change)? By: Tilghman Lesher (tilghman) 2006-01-22 12:08:32.000-0600 No, we simply hadn't updated the field yet. By: wes (whoiswes) 2006-02-10 13:09:03.000-0600 has this been committed to trunk yet? By: Kevin P. Fleming (kpfleming) 2006-02-14 19:52:36.000-0600 Committed to trunk, although I had to write the documentation in the sample config file myself :-( By: Digium Subversion (svnbot) 2008-01-15 16:48:12.000-0600 Repository: asterisk Revision: 10163 U   trunk/apps/app_queue.c U   trunk/configs/queues.conf.sample ------------------------------------------------------------------------ r10163 | kpfleming | 2008-01-15 16:48:12 -0600 (Tue, 15 Jan 2008) | 2 lines add option to avoid calling members whose channels are 'in use' (issue ASTERISK-6155, plus documentation) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=10163