[Home]

Summary:ASTERISK-06144: [patch] added park command to manager interface
Reporter:Eric Hartley (ehartley)Labels:
Date Opened:2006-01-20 08:24:58.000-0600Date Closed:2006-03-06 17:13:05.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) lostmymind.diff
( 1) newmgrpark.diff
( 2) newpark.diff
( 3) park.diff
Description:app adds the command Park to the manager.
Comments:By: twisted (twisted) 2006-01-20 09:14:06.000-0600

Great idea, and great job - However, since this is only a manager event, it should be worked into where our existing parking is located, in res_features.c.  

Otherwise, this is a very useful feature!
By: Eric Hartley (ehartley) 2006-01-20 13:18:19.000-0600

moved code to res_features -- disregard managerpark.diff.  new patch in park.diff
By: Olle Johansson (oej) 2006-01-20 14:51:19.000-0600

What is the difference between this and simply transfering to the parking lot?

is there any way you can return the actual parking lot if parking succeeded?

You have some small formatting issues that  needs to be fix, indentation errors.
By: Eric Hartley (ehartley) 2006-01-22 14:31:16.000-0600

this function adds the ability to initiate park from the manager interface.  I wrote it for a switchboard application that needed to be able to park.  Using the redirect command crashed the call.  The feedback to the application comes from the event message that ast_masq_park_call generates, as well as playing the digits of the parking lot to the call leg on Channel2.

Can you explain my indention errors?  I've reread the guidlines I found online, but I don't see what's wrong.

Thanks
By: Russell Bryant (russell) 2006-01-24 22:12:24.000-0600

In response to your email to the asterisk-dev mailing list, it appears as if you have used spaces instead of tabs for your indentation in the last two hunks of the patch.  The rest of the patch is correctly using spaces.  Other than that, the formatting looks fine.
By: Eric Hartley (ehartley) 2006-01-25 07:58:11.000-0600

Found and fixed indention errors (thanks Russell).

New patch in newpark.diff
By: Olle Johansson (oej) 2006-01-25 09:28:56.000-0600

You are mising spaces in at least these places:

sscanf(timeout,"%d",&to);
snprintf(buf, sizeof(buf), "Channel does not exist: %s",channel);
snprintf(buf, sizeof(buf), "Channel does not exist: %s",channel2);
sscanf(timeout,"%d",&to);

Spaces are rather cheap if you buy them in bulk and adding them makes the code more readable. And, they are required by the coding guidelines ;-)
By: Matt Riddell (zx81) 2006-01-25 18:46:25.000-0600

"Using the redirect command crashed the call. "

Wouldn't it make more sense to fix redirect then?
By: Eric Hartley (ehartley) 2006-01-25 20:30:43.000-0600

fixed spacing...hopefully correct this time. (I really did reread all of this again).
By: twisted (twisted) 2006-01-26 10:04:22.000-0600

ZX81, Redirecting a channel to park, while it will park the call, won't give back the second channel the parking slot.   It's a hack to do it that way, IMO, and I don't think redirect is broken, as we use it on a daily basis here.
By: Matt Riddell (zx81) 2006-01-26 10:37:22.000-0600

:)

Yeah, I remember now, I saw that about a year ago when writing SineAsterPanel.
By: Eric Hartley (ehartley) 2006-01-26 20:59:34.000-0600

with all the formatting issues, and the first change, I just realized I used the wrong version of the file.  Please consider lostmymind.diff and delete all previous files.
By: twisted (twisted) 2006-02-09 15:44:27.000-0600

Let's revisit this.
By: Tilghman Lesher (tilghman) 2006-03-06 17:13:05.000-0600

Committed to trunk