ASTERISK-06140: [patch] Codec formatting fixes and doxygen updates

[Home]

Summary: ASTERISK-06140: [patch] Codec formatting fixes and doxygen updates

Reporter: Jason Parker (jparker) Labels:

Date Opened: 2006-01-19 17:04:34.000-0600 Date Closed: 2008-01-15 16:21:20.000-0600

Priority: Trivial Regression? No

Status: Closed/Complete Components: Core/CodecInterface

Versions: Frequency of
Occurrence

Related
Issues:

Environment: Attachments: ( 0) codec_a_mu-formatting.diff
( 1) codec_adpcm-formatting.diff
( 2) codec_alaw-formatting.diff
( 3) codec_ulaw-formatting.diff

Description: Just for fun, I ran a diff between the ulaw and alaw codecs, and noticed several things.

1) alaw had more doxygen comments than ulaw, even though the same exact comments were used for both
2) the formatting between the two was quite different, even in some instances where it was the same exact code
3) the formatting on both files could use a bit of work

Comments: By: Jason Parker (jparker) 2006-01-19 17:11:04.000-0600

Here are some of the things that changed.

1) whitespace fixes - convert spaces to tabs
2) put { on same line as if - "if\n{" becomes "if {"
3) "fix" multi-line function declarations - "int\nusecount" becomes "int usecount"
4) remove whitespace between function name and args - "ast_myfunction ()" becomes "ast_myfunction()"
5) add to ulaw, doxygen comments which were in alaw
6) a few general whitespace fixes

Next up - codec_a_mu.c
By: Jason Parker (jparker) 2006-01-19 17:23:49.000-0600

Reuploaded ulaw and alaw patch.

Uploaded a_mu patch.
By: Jason Parker (jparker) 2006-01-19 18:25:01.000-0600

and adpcm
By: Russell Bryant (russell) 2006-01-20 16:23:19.000-0600

added to the trunk, rev 8360, thanks!
By: Digium Subversion (svnbot) 2008-01-15 16:19:58.000-0600

Repository: asterisk
Revision: 8360

U trunk/codecs/codec_a_mu.c
U trunk/codecs/codec_adpcm.c
U trunk/codecs/codec_alaw.c
U trunk/codecs/codec_ulaw.c

------------------------------------------------------------------------
r8360 | russell | 2008-01-15 16:19:58 -0600 (Tue, 15 Jan 2008) | 2 lines

formatting and doxygen fixes (issue ASTERISK-6140)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8360
By: Digium Subversion (svnbot) 2008-01-15 16:20:34.000-0600

Repository: asterisk
Revision: 8397

_U team/russell/make_output/
U team/russell/make_output/apps/app_queue.c
U team/russell/make_output/callerid.c
U team/russell/make_output/codecs/codec_a_mu.c
U team/russell/make_output/codecs/codec_adpcm.c
U team/russell/make_output/codecs/codec_alaw.c
U team/russell/make_output/codecs/codec_g723_1.c
U team/russell/make_output/codecs/codec_g726.c
U team/russell/make_output/codecs/codec_gsm.c
U team/russell/make_output/codecs/codec_ilbc.c
U team/russell/make_output/codecs/codec_lpc10.c
U team/russell/make_output/codecs/codec_speex.c
U team/russell/make_output/codecs/codec_ulaw.c
U team/russell/make_output/codecs/gsm/Makefile
U team/russell/make_output/configs/alsa.conf.sample
U team/russell/make_output/configs/sip.conf.sample
U team/russell/make_output/configs/zapata.conf.sample
A team/russell/make_output/doc/README.callingpres
U team/russell/make_output/formats/format_pcm.c
U team/russell/make_output/formats/format_pcm_alaw.c
U team/russell/make_output/include/asterisk/channel.h
U team/russell/make_output/include/asterisk/utils.h
U team/russell/make_output/pbx.c
U team/russell/make_output/res/res_agi.c

------------------------------------------------------------------------
r8397 | russell | 2008-01-15 16:20:34 -0600 (Tue, 15 Jan 2008) | 131 lines

Merged revisions 8336,8338,8345-8346,8348,8356-8357,8359-8362,8368,8370-8372,8378-8381,8387,8393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8336 | oej | 2006-01-20 09:32:30 -0500 (Fri, 20 Jan 2006) | 4 lines

- Add DOC file about caller ID presentation values
- Add callingpres to sip.conf
- Add reference to README.callingpres from zapata.conf

................
r8338 | kpfleming | 2006-01-20 12:27:51 -0500 (Fri, 20 Jan 2006) | 2 lines

eliminate compiler warnings from recent const-ification

................
r8345 | mattf | 2006-01-20 13:17:46 -0500 (Fri, 20 Jan 2006) | 2 lines

Update config. Apprently default doesn't always work now.

................
r8346 | mattf | 2006-01-20 13:18:40 -0500 (Fri, 20 Jan 2006) | 2 lines

Change chan_alsa to default open the first sound card device

................
r8348 | russell | 2006-01-20 13:40:24 -0500 (Fri, 20 Jan 2006) | 10 lines

Merged revisions 8347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8347 | russell | 2006-01-20 13:34:42 -0500 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........

................
r8356 | russell | 2006-01-20 14:24:42 -0500 (Fri, 20 Jan 2006) | 11 lines

- move ast_strdupa from channel.h to utils.h
- attempt to log an error message if the __builtin_alloca inside of ast_strdupa
fails.
- document the fact that it is known and intended behavior for ast_strdupa to
cause Asterisk to crash if the alloca fails
- use __builtin_expect when checking for allocation failure in all of the
allocation wrappers

New Janitor Project! Anywhere that we check for a successful allocation after
a call to ast_strdupa is unnecessary and should be removed.

................
r8357 | mattf | 2006-01-20 16:36:33 -0500 (Fri, 20 Jan 2006) | 2 lines

Fix for formats so they give better output on failure conditions. (ASTERISK-5984)

................
r8359 | mattf | 2006-01-20 18:19:49 -0500 (Fri, 20 Jan 2006) | 2 lines

Fix comments in sip.conf (ASTERISK-5977)

................
r8360 | russell | 2006-01-20 18:23:00 -0500 (Fri, 20 Jan 2006) | 2 lines

formatting and doxygen fixes (issue ASTERISK-6140)

................
r8361 | mattf | 2006-01-20 18:28:37 -0500 (Fri, 20 Jan 2006) | 2 lines

fix for codec_gsm on ia64 (ASTERISK-6134)

................
r8362 | russell | 2006-01-20 19:42:25 -0500 (Fri, 20 Jan 2006) | 2 lines

remove some useless checks after calls to ast_strdupa

................
r8368 | russell | 2006-01-20 22:09:01 -0500 (Fri, 20 Jan 2006) | 2 lines

remove optimization where its benefits are negligible

................
r8370 | tilghman | 2006-01-21 00:05:45 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 6096 - callerid_parse cleanup

................
r8371 | tilghman | 2006-01-21 00:15:56 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 5515 - Devicestate and API documentation update

................
r8372 | tilghman | 2006-01-21 00:22:18 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 4872 - Make Asterisk paths available to AGIs via environmental variables

................
r8378 | russell | 2006-01-21 03:01:24 -0500 (Sat, 21 Jan 2006) | 2 lines

remove some useless checks of the result of ast_strdupa

................
r8379 | russell | 2006-01-21 03:13:12 -0500 (Sat, 21 Jan 2006) | 2 lines

remove lots of useless checks of the result of ast_strdupa

................
r8380 | russell | 2006-01-21 03:23:57 -0500 (Sat, 21 Jan 2006) | 2 lines

remove useless checks of the result of ast_strdupa

................
r8381 | russell | 2006-01-21 03:45:39 -0500 (Sat, 21 Jan 2006) | 2 lines

conversions to use allocation wrappers (issue ASTERISK-6117)

................
r8387 | russell | 2006-01-21 12:50:04 -0500 (Sat, 21 Jan 2006) | 3 lines

revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)

................
r8393 | russell | 2006-01-21 13:11:40 -0500 (Sat, 21 Jan 2006) | 3 lines

don't do the memcpy inside of ast_strdupa if we know that __builtin_alloca
was not successful

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8397
By: Digium Subversion (svnbot) 2008-01-15 16:20:37.000-0600

Repository: asterisk
Revision: 8399

_U team/russell/autoconf_and_menuselect/
U team/russell/autoconf_and_menuselect/apps/app_queue.c
U team/russell/autoconf_and_menuselect/callerid.c
U team/russell/autoconf_and_menuselect/codecs/codec_a_mu.c
U team/russell/autoconf_and_menuselect/codecs/codec_adpcm.c
U team/russell/autoconf_and_menuselect/codecs/codec_alaw.c
U team/russell/autoconf_and_menuselect/codecs/codec_g723_1.c
U team/russell/autoconf_and_menuselect/codecs/codec_g726.c
U team/russell/autoconf_and_menuselect/codecs/codec_gsm.c
U team/russell/autoconf_and_menuselect/codecs/codec_ilbc.c
U team/russell/autoconf_and_menuselect/codecs/codec_lpc10.c
U team/russell/autoconf_and_menuselect/codecs/codec_speex.c
U team/russell/autoconf_and_menuselect/codecs/codec_ulaw.c
U team/russell/autoconf_and_menuselect/codecs/gsm/Makefile
U team/russell/autoconf_and_menuselect/configs/alsa.conf.sample
U team/russell/autoconf_and_menuselect/configs/sip.conf.sample
U team/russell/autoconf_and_menuselect/configs/zapata.conf.sample
A team/russell/autoconf_and_menuselect/doc/README.callingpres
U team/russell/autoconf_and_menuselect/formats/format_pcm.c
U team/russell/autoconf_and_menuselect/formats/format_pcm_alaw.c
U team/russell/autoconf_and_menuselect/include/asterisk/channel.h
U team/russell/autoconf_and_menuselect/include/asterisk/utils.h
U team/russell/autoconf_and_menuselect/pbx.c
U team/russell/autoconf_and_menuselect/res/res_agi.c

------------------------------------------------------------------------
r8399 | russell | 2008-01-15 16:20:37 -0600 (Tue, 15 Jan 2008) | 131 lines

Merged revisions 8336,8338,8345-8346,8348,8356-8357,8359-8362,8368,8370-8372,8378-8381,8387,8393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8336 | oej | 2006-01-20 09:32:30 -0500 (Fri, 20 Jan 2006) | 4 lines

- Add DOC file about caller ID presentation values
- Add callingpres to sip.conf
- Add reference to README.callingpres from zapata.conf

................
r8338 | kpfleming | 2006-01-20 12:27:51 -0500 (Fri, 20 Jan 2006) | 2 lines

eliminate compiler warnings from recent const-ification

................
r8345 | mattf | 2006-01-20 13:17:46 -0500 (Fri, 20 Jan 2006) | 2 lines

Update config. Apprently default doesn't always work now.

................
r8346 | mattf | 2006-01-20 13:18:40 -0500 (Fri, 20 Jan 2006) | 2 lines

Change chan_alsa to default open the first sound card device

................
r8348 | russell | 2006-01-20 13:40:24 -0500 (Fri, 20 Jan 2006) | 10 lines

Merged revisions 8347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8347 | russell | 2006-01-20 13:34:42 -0500 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........

................
r8356 | russell | 2006-01-20 14:24:42 -0500 (Fri, 20 Jan 2006) | 11 lines

- move ast_strdupa from channel.h to utils.h
- attempt to log an error message if the __builtin_alloca inside of ast_strdupa
fails.
- document the fact that it is known and intended behavior for ast_strdupa to
cause Asterisk to crash if the alloca fails
- use __builtin_expect when checking for allocation failure in all of the
allocation wrappers

New Janitor Project! Anywhere that we check for a successful allocation after
a call to ast_strdupa is unnecessary and should be removed.

................
r8357 | mattf | 2006-01-20 16:36:33 -0500 (Fri, 20 Jan 2006) | 2 lines

Fix for formats so they give better output on failure conditions. (ASTERISK-5984)

................
r8359 | mattf | 2006-01-20 18:19:49 -0500 (Fri, 20 Jan 2006) | 2 lines

Fix comments in sip.conf (ASTERISK-5977)

................
r8360 | russell | 2006-01-20 18:23:00 -0500 (Fri, 20 Jan 2006) | 2 lines

formatting and doxygen fixes (issue ASTERISK-6140)

................
r8361 | mattf | 2006-01-20 18:28:37 -0500 (Fri, 20 Jan 2006) | 2 lines

fix for codec_gsm on ia64 (ASTERISK-6134)

................
r8362 | russell | 2006-01-20 19:42:25 -0500 (Fri, 20 Jan 2006) | 2 lines

remove some useless checks after calls to ast_strdupa

................
r8368 | russell | 2006-01-20 22:09:01 -0500 (Fri, 20 Jan 2006) | 2 lines

remove optimization where its benefits are negligible

................
r8370 | tilghman | 2006-01-21 00:05:45 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 6096 - callerid_parse cleanup

................
r8371 | tilghman | 2006-01-21 00:15:56 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 5515 - Devicestate and API documentation update

................
r8372 | tilghman | 2006-01-21 00:22:18 -0500 (Sat, 21 Jan 2006) | 2 lines

Bug 4872 - Make Asterisk paths available to AGIs via environmental variables

................
r8378 | russell | 2006-01-21 03:01:24 -0500 (Sat, 21 Jan 2006) | 2 lines

remove some useless checks of the result of ast_strdupa

................
r8379 | russell | 2006-01-21 03:13:12 -0500 (Sat, 21 Jan 2006) | 2 lines

remove lots of useless checks of the result of ast_strdupa

................
r8380 | russell | 2006-01-21 03:23:57 -0500 (Sat, 21 Jan 2006) | 2 lines

remove useless checks of the result of ast_strdupa

................
r8381 | russell | 2006-01-21 03:45:39 -0500 (Sat, 21 Jan 2006) | 2 lines

conversions to use allocation wrappers (issue ASTERISK-6117)

................
r8387 | russell | 2006-01-21 12:50:04 -0500 (Sat, 21 Jan 2006) | 3 lines

revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)

................
r8393 | russell | 2006-01-21 13:11:40 -0500 (Sat, 21 Jan 2006) | 3 lines

don't do the memcpy inside of ast_strdupa if we know that __builtin_alloca
was not successful

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8399
By: Digium Subversion (svnbot) 2008-01-15 16:20:54.000-0600

Repository: asterisk
Revision: 8416

_U team/murf/AEL2/
U team/murf/AEL2/apps/Makefile
U team/murf/AEL2/apps/app_authenticate.c
U team/murf/AEL2/apps/app_chanspy.c
U team/murf/AEL2/apps/app_curl.c
U team/murf/AEL2/apps/app_db.c
U team/murf/AEL2/apps/app_dial.c
U team/murf/AEL2/apps/app_dictate.c
U team/murf/AEL2/apps/app_directory.c
U team/murf/AEL2/apps/app_disa.c
U team/murf/AEL2/apps/app_exec.c
U team/murf/AEL2/apps/app_externalivr.c
U team/murf/AEL2/apps/app_festival.c
U team/murf/AEL2/apps/app_hasnewvoicemail.c
U team/murf/AEL2/apps/app_image.c
U team/murf/AEL2/apps/app_macro.c
U team/murf/AEL2/apps/app_meetme.c
U team/murf/AEL2/apps/app_mixmonitor.c
U team/murf/AEL2/apps/app_osplookup.c
U team/murf/AEL2/apps/app_page.c
U team/murf/AEL2/apps/app_playback.c
U team/murf/AEL2/apps/app_privacy.c
U team/murf/AEL2/apps/app_queue.c
U team/murf/AEL2/apps/app_random.c
U team/murf/AEL2/apps/app_read.c
U team/murf/AEL2/apps/app_readfile.c
U team/murf/AEL2/apps/app_record.c
U team/murf/AEL2/apps/app_sayunixtime.c
U team/murf/AEL2/apps/app_senddtmf.c
U team/murf/AEL2/apps/app_sendtext.c
U team/murf/AEL2/apps/app_setcallerid.c
U team/murf/AEL2/apps/app_skel.c
U team/murf/AEL2/apps/app_sql_postgres.c
U team/murf/AEL2/apps/app_stack.c
U team/murf/AEL2/apps/app_talkdetect.c
U team/murf/AEL2/apps/app_transfer.c
U team/murf/AEL2/apps/app_url.c
U team/murf/AEL2/apps/app_userevent.c
U team/murf/AEL2/apps/app_verbose.c
U team/murf/AEL2/apps/app_voicemail.c
U team/murf/AEL2/apps/app_while.c
U team/murf/AEL2/apps/app_zapras.c
U team/murf/AEL2/callerid.c
U team/murf/AEL2/channel.c
U team/murf/AEL2/channels/chan_agent.c
U team/murf/AEL2/channels/chan_iax2.c
U team/murf/AEL2/channels/chan_sip.c
U team/murf/AEL2/codecs/codec_a_mu.c
U team/murf/AEL2/codecs/codec_adpcm.c
U team/murf/AEL2/codecs/codec_alaw.c
U team/murf/AEL2/codecs/codec_g723_1.c
U team/murf/AEL2/codecs/codec_g726.c
U team/murf/AEL2/codecs/codec_gsm.c
U team/murf/AEL2/codecs/codec_ilbc.c
U team/murf/AEL2/codecs/codec_lpc10.c
U team/murf/AEL2/codecs/codec_speex.c
U team/murf/AEL2/codecs/codec_ulaw.c
U team/murf/AEL2/codecs/gsm/Makefile
U team/murf/AEL2/configs/alsa.conf.sample
U team/murf/AEL2/configs/sip.conf.sample
U team/murf/AEL2/configs/zapata.conf.sample
A team/murf/AEL2/doc/README.callingpres
U team/murf/AEL2/formats/format_pcm.c
U team/murf/AEL2/formats/format_pcm_alaw.c
U team/murf/AEL2/funcs/func_cdr.c
U team/murf/AEL2/funcs/func_cut.c
U team/murf/AEL2/funcs/func_logic.c
U team/murf/AEL2/funcs/func_math.c
U team/murf/AEL2/funcs/func_md5.c
U team/murf/AEL2/funcs/func_odbc.c
U team/murf/AEL2/funcs/func_rand.c
U team/murf/AEL2/funcs/func_strings.c
U team/murf/AEL2/include/asterisk/channel.h
U team/murf/AEL2/include/asterisk/utils.h
U team/murf/AEL2/pbx.c
U team/murf/AEL2/res/res_agi.c
U team/murf/AEL2/res/res_crypto.c
U team/murf/AEL2/res/res_features.c
U team/murf/AEL2/res/res_indications.c
U team/murf/AEL2/res/res_monitor.c
U team/murf/AEL2/res/res_musiconhold.c
U team/murf/AEL2/res/res_osp.c

------------------------------------------------------------------------
r8416 | murf | 2008-01-15 16:20:54 -0600 (Tue, 15 Jan 2008) | 186 lines

Merged revisions 8336,8338,8345-8346,8348,8356-8357,8359-8362,8368,8370-8372,8378-8381,8387,8393,8401-8404,8407-8411,8413 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r8336 | oej | 2006-01-20 07:32:30 -0700 (Fri, 20 Jan 2006) | 4 lines

- Add DOC file about caller ID presentation values
- Add callingpres to sip.conf
- Add reference to README.callingpres from zapata.conf

................
r8338 | kpfleming | 2006-01-20 10:27:51 -0700 (Fri, 20 Jan 2006) | 2 lines

eliminate compiler warnings from recent const-ification

................
r8345 | mattf | 2006-01-20 11:17:46 -0700 (Fri, 20 Jan 2006) | 2 lines

Update config. Apprently default doesn't always work now.

................
r8346 | mattf | 2006-01-20 11:18:40 -0700 (Fri, 20 Jan 2006) | 2 lines

Change chan_alsa to default open the first sound card device

................
r8348 | russell | 2006-01-20 11:40:24 -0700 (Fri, 20 Jan 2006) | 10 lines

Merged revisions 8347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r8347 | russell | 2006-01-20 13:34:42 -0500 (Fri, 20 Jan 2006) | 2 lines

fix invalid value of prev_q (issue ASTERISK-6142)

........

................
r8356 | russell | 2006-01-20 12:24:42 -0700 (Fri, 20 Jan 2006) | 11 lines

- move ast_strdupa from channel.h to utils.h
- attempt to log an error message if the __builtin_alloca inside of ast_strdupa
fails.
- document the fact that it is known and intended behavior for ast_strdupa to
cause Asterisk to crash if the alloca fails
- use __builtin_expect when checking for allocation failure in all of the
allocation wrappers

New Janitor Project! Anywhere that we check for a successful allocation after
a call to ast_strdupa is unnecessary and should be removed.

................
r8357 | mattf | 2006-01-20 14:36:33 -0700 (Fri, 20 Jan 2006) | 2 lines

Fix for formats so they give better output on failure conditions. (ASTERISK-5984)

................
r8359 | mattf | 2006-01-20 16:19:49 -0700 (Fri, 20 Jan 2006) | 2 lines

Fix comments in sip.conf (ASTERISK-5977)

................
r8360 | russell | 2006-01-20 16:23:00 -0700 (Fri, 20 Jan 2006) | 2 lines

formatting and doxygen fixes (issue ASTERISK-6140)

................
r8361 | mattf | 2006-01-20 16:28:37 -0700 (Fri, 20 Jan 2006) | 2 lines

fix for codec_gsm on ia64 (ASTERISK-6134)

................
r8362 | russell | 2006-01-20 17:42:25 -0700 (Fri, 20 Jan 2006) | 2 lines

remove some useless checks after calls to ast_strdupa

................
r8368 | russell | 2006-01-20 20:09:01 -0700 (Fri, 20 Jan 2006) | 2 lines

remove optimization where its benefits are negligible

................
r8370 | tilghman | 2006-01-20 22:05:45 -0700 (Fri, 20 Jan 2006) | 2 lines

Bug 6096 - callerid_parse cleanup

................
r8371 | tilghman | 2006-01-20 22:15:56 -0700 (Fri, 20 Jan 2006) | 2 lines

Bug 5515 - Devicestate and API documentation update

................
r8372 | tilghman | 2006-01-20 22:22:18 -0700 (Fri, 20 Jan 2006) | 2 lines

Bug 4872 - Make Asterisk paths available to AGIs via environmental variables

................
r8378 | russell | 2006-01-21 01:01:24 -0700 (Sat, 21 Jan 2006) | 2 lines

remove some useless checks of the result of ast_strdupa

................
r8379 | russell | 2006-01-21 01:13:12 -0700 (Sat, 21 Jan 2006) | 2 lines

remove lots of useless checks of the result of ast_strdupa

................
r8380 | russell | 2006-01-21 01:23:57 -0700 (Sat, 21 Jan 2006) | 2 lines

remove useless checks of the result of ast_strdupa

................
r8381 | russell | 2006-01-21 01:45:39 -0700 (Sat, 21 Jan 2006) | 2 lines

conversions to use allocation wrappers (issue ASTERISK-6117)

................
r8387 | russell | 2006-01-21 10:50:04 -0700 (Sat, 21 Jan 2006) | 3 lines

revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)

................
r8393 | russell | 2006-01-21 11:11:40 -0700 (Sat, 21 Jan 2006) | 3 lines

don't do the memcpy inside of ast_strdupa if we know that __builtin_alloca
was not successful

................
r8401 | russell | 2006-01-21 13:20:06 -0700 (Sat, 21 Jan 2006) | 3 lines

finish reverting my pass through the tree to remove checks of the result of
ast_strdupa, this one is revision 8362

................
r8402 | tilghman | 2006-01-21 13:32:17 -0700 (Sat, 21 Jan 2006) | 2 lines

Bug 5936 - Cannot AddQueueMember on realtime queue, if queue not yet loaded (different fix than 1.2)

................
r8403 | russell | 2006-01-21 13:57:06 -0700 (Sat, 21 Jan 2006) | 2 lines

on this pass, only remove duplicate log messages

................
r8404 | russell | 2006-01-21 13:58:57 -0700 (Sat, 21 Jan 2006) | 1 line

................
r8407 | russell | 2006-01-21 14:29:06 -0700 (Sat, 21 Jan 2006) | 2 lines

clean up formatting to conform to coding guidelines and fix some typos (issue ASTERISK-6101)

................
r8408 | russell | 2006-01-21 14:50:09 -0700 (Sat, 21 Jan 2006) | 5 lines

- conversion to allocation wrappers
- get rid of some compiler warnings due to usused variables and const-ification
- remove some unnecessary uses of malloc/strncpy/free and replace with ast_strdupa
(based on the patch from issue ASTERISK-6115)

................
r8409 | russell | 2006-01-21 14:57:01 -0700 (Sat, 21 Jan 2006) | 2 lines

oops, don't build app_sql_postgres by default ...

................
r8410 | russell | 2006-01-21 15:09:06 -0700 (Sat, 21 Jan 2006) | 5 lines

- conversions to allocation wrappers
- replace malloc/memset with ast_calloc
- replace malloc/ast_copy_string with ast_strdup
(based on patch from issue ASTERISK-6139)

................
r8411 | russell | 2006-01-21 16:05:19 -0700 (Sat, 21 Jan 2006) | 2 lines

const-ify some fields in the ast_exten and ast_include structures (issue ASTERISK-6110)

................
r8413 | russell | 2006-01-21 16:17:52 -0700 (Sat, 21 Jan 2006) | 1 line

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8416
By: Digium Subversion (svnbot) 2008-01-15 16:21:20.000-0600

Repository: asterisk
Revision: 8441

_U team/oej/astum/
U team/oej/astum/apps/Makefile
U team/oej/astum/apps/app_authenticate.c
U team/oej/astum/apps/app_chanspy.c
U team/oej/astum/apps/app_curl.c
U team/oej/astum/apps/app_db.c
U team/oej/astum/apps/app_dial.c
U team/oej/astum/apps/app_dictate.c
U team/oej/astum/apps/app_directory.c
U team/oej/astum/apps/app_disa.c
U team/oej/astum/apps/app_exec.c
U team/oej/astum/apps/app_externalivr.c
U team/oej/astum/apps/app_festival.c
U team/oej/astum/apps/app_hasnewvoicemail.c
U team/oej/astum/apps/app_image.c
U team/oej/astum/apps/app_macro.c
U team/oej/astum/apps/app_meetme.c
U team/oej/astum/apps/app_mixmonitor.c
U team/oej/astum/apps/app_osplookup.c
U team/oej/astum/apps/app_page.c
U team/oej/astum/apps/app_parkandannounce.c
U team/oej/astum/apps/app_playback.c
U team/oej/astum/apps/app_privacy.c
U team/oej/astum/apps/app_queue.c
U team/oej/astum/apps/app_random.c
U team/oej/astum/apps/app_read.c
U team/oej/astum/apps/app_readfile.c
U team/oej/astum/apps/app_record.c
U team/oej/astum/apps/app_sayunixtime.c
U team/oej/astum/apps/app_senddtmf.c
U team/oej/astum/apps/app_sendtext.c
U team/oej/astum/apps/app_setcallerid.c
U team/oej/astum/apps/app_skel.c
U team/oej/astum/apps/app_sql_postgres.c
U team/oej/astum/apps/app_stack.c
U team/oej/astum/apps/app_talkdetect.c
U team/oej/astum/apps/app_transfer.c
U team/oej/astum/apps/app_url.c
U team/oej/astum/apps/app_userevent.c
U team/oej/astum/apps/app_verbose.c
U team/oej/astum/apps/app_voicemail.c
U team/oej/astum/apps/app_while.c
U team/oej/astum/apps/app_zapras.c
U team/oej/astum/callerid.c
U team/oej/astum/channel.c
U team/oej/astum/channels/chan_agent.c
U team/oej/astum/channels/chan_iax2.c
U team/oej/astum/channels/chan_mgcp.c
U team/oej/astum/channels/chan_sip.c
U team/oej/astum/codecs/codec_a_mu.c
U team/oej/astum/codecs/codec_adpcm.c
U team/oej/astum/codecs/codec_alaw.c
U team/oej/astum/codecs/codec_g723_1.c
U team/oej/astum/codecs/codec_g726.c
U team/oej/astum/codecs/codec_gsm.c
U team/oej/astum/codecs/codec_ilbc.c
U team/oej/astum/codecs/codec_lpc10.c
U team/oej/astum/codecs/codec_speex.c
U team/oej/astum/codecs/codec_ulaw.c
U team/oej/astum/codecs/gsm/Makefile
U team/oej/astum/configs/sip.conf.sample
U team/oej/astum/doc/README.variables
U team/oej/astum/funcs/func_cdr.c
U team/oej/astum/funcs/func_cut.c
U team/oej/astum/funcs/func_logic.c
U team/oej/astum/funcs/func_math.c
U team/oej/astum/funcs/func_md5.c
U team/oej/astum/funcs/func_odbc.c
U team/oej/astum/funcs/func_rand.c
U team/oej/astum/funcs/func_strings.c
U team/oej/astum/include/asterisk/utils.h
U team/oej/astum/pbx.c
U team/oej/astum/res/res_agi.c
U team/oej/astum/res/res_crypto.c
U team/oej/astum/res/res_features.c
U team/oej/astum/res/res_indications.c
U team/oej/astum/res/res_monitor.c
U team/oej/astum/res/res_musiconhold.c
U team/oej/astum/res/res_osp.c

------------------------------------------------------------------------
r8441 | oej | 2008-01-15 16:21:19 -0600 (Tue, 15 Jan 2008) | 167 lines

Merged revisions 8359-8362,8368,8370-8372,8378-8381,8387,8393,8401-8404,8407-8411,8413,8420-8422,8426,8428,8432,8436 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r8359 | mattf | 2006-01-21 00:19:49 +0100 (Sat, 21 Jan 2006) | 2 lines

Fix comments in sip.conf (ASTERISK-5977)

........
r8360 | russell | 2006-01-21 00:23:00 +0100 (Sat, 21 Jan 2006) | 2 lines

formatting and doxygen fixes (issue ASTERISK-6140)

........
r8361 | mattf | 2006-01-21 00:28:37 +0100 (Sat, 21 Jan 2006) | 2 lines

fix for codec_gsm on ia64 (ASTERISK-6134)

........
r8362 | russell | 2006-01-21 01:42:25 +0100 (Sat, 21 Jan 2006) | 2 lines

remove some useless checks after calls to ast_strdupa

........
r8368 | russell | 2006-01-21 04:09:01 +0100 (Sat, 21 Jan 2006) | 2 lines

remove optimization where its benefits are negligible

........
r8370 | tilghman | 2006-01-21 06:05:45 +0100 (Sat, 21 Jan 2006) | 2 lines

Bug 6096 - callerid_parse cleanup

........
r8371 | tilghman | 2006-01-21 06:15:56 +0100 (Sat, 21 Jan 2006) | 2 lines

Bug 5515 - Devicestate and API documentation update

........
r8372 | tilghman | 2006-01-21 06:22:18 +0100 (Sat, 21 Jan 2006) | 2 lines

Bug 4872 - Make Asterisk paths available to AGIs via environmental variables

........
r8378 | russell | 2006-01-21 09:01:24 +0100 (Sat, 21 Jan 2006) | 2 lines

remove some useless checks of the result of ast_strdupa

........
r8379 | russell | 2006-01-21 09:13:12 +0100 (Sat, 21 Jan 2006) | 2 lines

remove lots of useless checks of the result of ast_strdupa

........
r8380 | russell | 2006-01-21 09:23:57 +0100 (Sat, 21 Jan 2006) | 2 lines

remove useless checks of the result of ast_strdupa

........
r8381 | russell | 2006-01-21 09:45:39 +0100 (Sat, 21 Jan 2006) | 2 lines

conversions to use allocation wrappers (issue ASTERISK-6117)

........
r8387 | russell | 2006-01-21 18:50:04 +0100 (Sat, 21 Jan 2006) | 3 lines

revert my pass through the tree to remove checks of the result of ast_strdupa
(revisions 8378 through 8381)

........
r8393 | russell | 2006-01-21 19:11:40 +0100 (Sat, 21 Jan 2006) | 3 lines

don't do the memcpy inside of ast_strdupa if we know that __builtin_alloca
was not successful

........
r8401 | russell | 2006-01-21 21:20:06 +0100 (Sat, 21 Jan 2006) | 3 lines

finish reverting my pass through the tree to remove checks of the result of
ast_strdupa, this one is revision 8362

........
r8402 | tilghman | 2006-01-21 21:32:17 +0100 (Sat, 21 Jan 2006) | 2 lines

Bug 5936 - Cannot AddQueueMember on realtime queue, if queue not yet loaded (different fix than 1.2)

........
r8403 | russell | 2006-01-21 21:57:06 +0100 (Sat, 21 Jan 2006) | 2 lines

on this pass, only remove duplicate log messages

........
r8404 | russell | 2006-01-21 21:58:57 +0100 (Sat, 21 Jan 2006) | 1 line

........
r8407 | russell | 2006-01-21 22:29:06 +0100 (Sat, 21 Jan 2006) | 2 lines

clean up formatting to conform to coding guidelines and fix some typos (issue ASTERISK-6101)

........
r8408 | russell | 2006-01-21 22:50:09 +0100 (Sat, 21 Jan 2006) | 5 lines

- conversion to allocation wrappers
- get rid of some compiler warnings due to usused variables and const-ification
- remove some unnecessary uses of malloc/strncpy/free and replace with ast_strdupa
(based on the patch from issue ASTERISK-6115)

........
r8409 | russell | 2006-01-21 22:57:01 +0100 (Sat, 21 Jan 2006) | 2 lines

oops, don't build app_sql_postgres by default ...

........
r8410 | russell | 2006-01-21 23:09:06 +0100 (Sat, 21 Jan 2006) | 5 lines

- conversions to allocation wrappers
- replace malloc/memset with ast_calloc
- replace malloc/ast_copy_string with ast_strdup
(based on patch from issue ASTERISK-6139)

........
r8411 | russell | 2006-01-22 00:05:19 +0100 (Sun, 22 Jan 2006) | 2 lines

const-ify some fields in the ast_exten and ast_include structures (issue ASTERISK-6110)

........
r8413 | russell | 2006-01-22 00:17:52 +0100 (Sun, 22 Jan 2006) | 1 line

........
r8420 | russell | 2006-01-22 03:06:33 +0100 (Sun, 22 Jan 2006) | 1 line

........
r8421 | russell | 2006-01-22 03:10:19 +0100 (Sun, 22 Jan 2006) | 3 lines

prevent writing outside of the provided workspace when calculating a
substring (issue ASTERISK-6111)

........
r8422 | russell | 2006-01-22 03:23:38 +0100 (Sun, 22 Jan 2006) | 2 lines

add 'show channeltype' CLI command (issue ASTERISK-5992, with small modifications)

........
r8426 | tilghman | 2006-01-22 08:18:02 +0100 (Sun, 22 Jan 2006) | 2 lines

Bug 6148 - Add PARKEDAT variable; also cleaned up application help to fit 80-column screen.

........
r8428 | tilghman | 2006-01-22 09:09:02 +0100 (Sun, 22 Jan 2006) | 2 lines

Bug 6262 - New function STRPTIME

........
r8432 | bweschke | 2006-01-22 16:08:51 +0100 (Sun, 22 Jan 2006) | 2 lines

Correct some scenarios where CALL_LIMIT could not be getting adjusted properly allowing chan_sip to send calls when it really shouldn't. Bug ASTERISK-5953

........
r8436 | tilghman | 2006-01-22 18:28:42 +0100 (Sun, 22 Jan 2006) | 2 lines

Bug 6312 - Macro janitor

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=8441