Summary:	ASTERISK-06136: [patch] No distinctive ring detection on TDM with cidstart=polarity
Reporter:	Marc McLaughlin (marc)	Labels:
Date Opened:	2006-01-19 09:02:40.000-0600	Date Closed:	2011-06-07 14:10:01
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_zap
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk_ringbegin.diff
Description:	When using cidstart=polarity and usedistinctiveringdetection=yes, the ring pattern is always detected as 0,0,0. This was first detected in v1.2.0. ****** STEPS TO REPRODUCE ****** zapata.conf : usedistinctiveringdetection=yes usecallerid=yes cidsignalling=v23 cidstart=polarity ****** ADDITIONAL INFORMATION ****** ZT_EVENT_RINGBEGIN handling is incomplete in chan_zap.c.  The only code that is run when this event occurs is to set p->ringt to p->ringt_base if in AST_STATE_RING.  With cidstart=polarity in the UK, we're in AST_STATE_PRERING, so p->ringt does not get set. In the Zaptel driver code I could not work out what the difference is meant to be between the two events RINGBEGIN (18) and RINGOFFHOOK (2).  So my patch just treats them the same.  This results in a working distinctive ring detection.  However the patterns reported are different to those for an X100P.
Comments:	By: Olle Johansson (oej) 2006-03-10 07:13:51.000-0600 mattf: Can you please take a look at this bug report? Thanks /oej By: Matthew Fredrickson (mattf) 2006-03-10 13:09:27.000-0600 Have you tried using the latest release of stable, as well as trunk?  I put a couple of patches in that could be related to this (IIRC) since the release of 1.2.2 By: Marc McLaughlin (marc) 2006-03-10 18:24:06.000-0600 Hi there.  Patch was last used with v1.2.4 Asterisk.  I'll try with the latest trunk and stable versions over the weekend. By: Marc McLaughlin (marc) 2006-03-16 04:45:18.000-0600 Apologies for the delay.  I have just tested against latest 1.2 SVN branch and distinctive ring fails both with and without the workaround.  Without the workaround patch, Asterisk also coredumps on exit. By: Marc McLaughlin (marc) 2006-03-16 04:50:30.000-0600 Using both the workaround patch and my history buffer patch (www.lusyn.com/resources/asterisk/usehist.htm) with cidstart=usehist, distinctive ring detection works. I'll see if I can get time to have a look at chan_zap to see what's changed with the event handling since 1.2.4. By: Marc McLaughlin (marc) 2006-03-17 04:53:12.000-0600 Have tried trunk this morning.  Same results unpatched (no DR + coredump on exit).  Patches do not work either, though (usehist patch fails to apply on asterisk).  Will rework patch and try again. By: Serge Vecher (serge-v) 2006-05-05 18:09:37 marc: any update on the patch? By: Marc McLaughlin (marc) 2006-06-02 05:02:47 Apologies - have ended up working full time.  Will reattempt against trunk this weekend. By: Serge Vecher (serge-v) 2006-06-27 09:53:55 any luck, marc? By: Serge Vecher (serge-v) 2006-07-07 15:54:45 I guess this is not that major By: Matthew Fredrickson (mattf) 2006-07-21 11:22:23 Lack of feedback.