Summary:	ASTERISK-06120: [branch] rewritten ast_extension_{match|core}
Reporter:	Luigi Rizzo (rizzo)	Labels:
Date Opened:	2006-01-18 05:19:14.000-0600	Date Closed:	2006-05-11 03:27:28
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) pbx-match.txt
Description:	I have been trying to cleanup the implementation of ast_extension_{match|core}() in pbx.c, in order to document them, get rid of the giant macro used in there, remove redundant code, and point out inconsistencies. The result is attached, for review. If the implementation looks correct (in term of specs - i had to reconstruct the behaviour from the source) i will supply a full patch for commit. ****** ADDITIONAL INFORMATION ****** There are some inconsistencies in the original code that i have preserved, but should be fixed before commit, e.g.: - in the case of no pattern, ast_extension_match() does a case-sensitive  comparison, whereas ast_extension_close() is case-insensitive.  One of them is almost surely wrong. - ast_extension_match() seems to treat '/' as an end-of-pattern  marker, whereas ast_extension_close() does not.
Comments:	By: Olle Johansson (oej) 2006-03-08 03:01:12.000-0600 Anyone that has looked on this work? Is it all wrong or should it be considered for inclusion? Rizzo: Is this kept up to date somewhere in your branch or do we need an update? By: Luigi Rizzo (rizzo) 2006-03-08 03:06:36.000-0600 all of the patches that i have on mantis are also in my branch asterisk/team/rizzo/base on SVN, which i regularly keep in sync with trunk, and is the code i have been using for months now for all my phones (admittedly, not a large setting with only ~10 sip phones, 4/5 providers and another iax peer). Unfortunately i haven't received any feedback on this particular patch. I think it is correct, it works for me at least and i haven't seen any crashes or unexplained failures. By: Luigi Rizzo (rizzo) 2006-05-08 13:49:47 taking care of this myself during astridevcon. By: Luigi Rizzo (rizzo) 2006-05-11 03:27:28 the new code implements what is described in this patch, modified according to the discussion we had in astridevcon in pisa.