| Summary: | ASTERISK-06095: add an additional return value to app_record.c | ||
| Reporter: | Fabian Müller (fanguin) | Labels: | |
| Date Opened: | 2006-01-16 08:08:20.000-0600 | Date Closed: | 2006-01-22 00:22:17.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_record |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Sometimes it is important to know if the record application reached the maximum recording duration. At the moment there is no special return value in this case. Can you please add res = -2; in line 266 in app_record.c. This change will make the record application return -2 if the maximum recording duration was reached. | ||
| Comments: | By: Tilghman Lesher (tilghman) 2006-01-16 10:26:24.000-0600 Return value doesn't actually do anything beyond letting the PBX know whether the application returned normally (0) or with a hangup condition (!0). If you want status, you'd need to set a variable, such as RECORDSTATUS. By: Fabian Müller (fanguin) 2006-01-17 09:06:28.000-0600 Sometimes the return value is important in an agi script. For example I execute the record application with $agi->exec from a phpagi script and evaluate the return value (which is -2 after the change) because I need to know if the maximum recording duration was reached. I understand that this change would break the general rule that the return value is not 0 on hangup condition so I guess this line is not acceptable for cvs. | ||